threads / patch / 15142

patchconfig.mak.in: Pass on LDFLAGS from configure

Subject: [PATCH] config.mak.in: Pass on LDFLAGS from configure

## tl;dr

2 messages between Aug 21, 2008 and Aug 22, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Neil Roberts· Aug 21, 2008, 19:38 UTC · lore

The configure script allows you to specify flags to pass to the linker step in the LDFLAGS environment variable but this was being ignored in the Makefile. Now a make variable gets set to the value passed down from the configure script.

Signed-off-by: Neil Roberts <bpeeluk@yahoo.co.uk>
---

I'm sending this again because I am incompetent. Sorry.

 config.mak.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to config.mak.in +1 −0

diff --git a/config.mak.in b/config.mak.in
index b776149..f67d673 100644
--- a/config.mak.in
+++ b/config.mak.in
@@ -3,6 +3,7 @@
 
 CC = @CC@
 CFLAGS = @CFLAGS@
+LDFLAGS = @LDFLAGS@
 AR = @AR@
 TAR = @TAR@
 #INSTALL = @INSTALL@		# needs install-sh or install.sh in sources

-- 
1.5.4.3

Andreas Färber· Aug 22, 2008, 11:56 UTC · re: Neil Roberts · lore

Re: [PATCH] config.mak.in: Pass on LDFLAGS from configure

Am 21.08.2008 um 21:38 schrieb Neil Roberts:

Show 7 quoted lines

> The configure script allows you to specify flags to pass to the linker
> step in the LDFLAGS environment variable but this was being ignored in
> the Makefile. Now a make variable gets set to the value passed down
> from the configure script.
>
> Signed-off-by: Neil Roberts <bpeeluk@yahoo.co.uk>
> ---

Show 13 quoted lines

> diff --git a/config.mak.in b/config.mak.in
> index b776149..f67d673 100644
> --- a/config.mak.in
> +++ b/config.mak.in
> @@ -3,6 +3,7 @@
>
> CC = @CC@
> CFLAGS = @CFLAGS@
> +LDFLAGS = @LDFLAGS@
> AR = @AR@
> TAR = @TAR@
> #INSTALL = @INSTALL@		# needs install-sh or install.sh in sources
> --

configure also uses CPPFLAGS for preprocessor options like -I/my/path, which are dropped as well. Could we fold them into CFLAGS while we're at it?

Andreas