# [EGIT PATCH] Enable diff=java for all *.java source files

3 messages from 2008-08-15 to 2008-08-18. Participants: Shawn O. Pearce, Robin Rosenberg.
Thread: https://gitlist.dev/t/15024

## Shawn O. Pearce, 2008-08-15 15:40

Subject: [EGIT PATCH] Enable diff=java for all *.java source files
Message-ID: <1218814822-23307-1-git-send-email-spearce@spearce.org>
URL: https://gitlist.dev/e/1218814822-23307-1-git-send-email-spearce%40spearce.org

```
This (usually) gets more reasonable function headers to
appear in the header line for a diff hunk.  Its slightly
better than the default C rules.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .gitattributes |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 .gitattributes

diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..f57840b
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.java diff=java
-- 
1.6.0.rc3.250.g8dd0

```

## Robin Rosenberg, 2008-08-18 05:38

Subject: Re: [EGIT PATCH] Enable diff=java for all *.java source files
Message-ID: <200808180738.21572.robin.rosenberg.lists@dewire.com>
URL: https://gitlist.dev/e/200808180738.21572.robin.rosenberg.lists%40dewire.com
In-Reply-To: <1218814822-23307-1-git-send-email-spearce@spearce.org>

```
fredagen den 15 augusti 2008 17.40.22 skrev Shawn O. Pearce:
> This (usually) gets more reasonable function headers to
> appear in the header line for a diff hunk.  Its slightly
> better than the default C rules.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>  .gitattributes |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>  create mode 100644 .gitattributes
> 
> diff --git a/.gitattributes b/.gitattributes
> new file mode 100644
> index 0000000..f57840b
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1 @@
> +*.java diff=java

Is there any reason this isn't the default in git?

-- robin

```

## Shawn O. Pearce, 2008-08-18 05:49

Subject: Re: [EGIT PATCH] Enable diff=java for all *.java source files
Message-ID: <20080818054937.GC7376@spearce.org>
URL: https://gitlist.dev/e/20080818054937.GC7376%40spearce.org
In-Reply-To: <200808180738.21572.robin.rosenberg.lists@dewire.com>

```
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> > diff --git a/.gitattributes b/.gitattributes
> > new file mode 100644
> > index 0000000..f57840b
> > --- /dev/null
> > +++ b/.gitattributes
> > @@ -0,0 +1 @@
> > +*.java diff=java
> 
> Is there any reason this isn't the default in git?

Because uh.  Nobody submitted a patch to make it the default?

It does seem like it would be a good idea to make it the default.
Its unlikely the C function header pattern is ever going to produce a
more reasonable hunk header for a *.java file than the Java pattern.

-- 
Shawn.

```
