# [PATCH] fix git-checkout-cache segfault on parisc 1 messages from 2005-08-13 to 2005-08-13. Participants: James Bottomley. Thread: https://gitlist.dev/t/1498 ## James Bottomley, 2005-08-13 15:29 Subject: [PATCH] fix git-checkout-cache segfault on parisc Message-ID: <1123946972.5115.4.camel@mulgrave> URL: https://gitlist.dev/e/1123946972.5115.4.camel%40mulgrave ``` This one I think is Linus' fault, so send him a brown paper bag with my complements ... The index cleanup code is executed via atexit() which is *after* main has completed, so the stack allocated cache_file has gone out of scope. Parisc seems to use stack in the destructor functions, so cache_file gets partially overwritten leading to the predictable disastrous consequences. Signed-off-by: James Bottomley --- James diff --git a/checkout-cache.c b/checkout-cache.c --- a/checkout-cache.c +++ b/checkout-cache.c @@ -80,10 +80,11 @@ static int checkout_all(void) static const char checkout_cache_usage[] = "git-checkout-cache [-u] [-q] [-a] [-f] [-n] [--prefix=] [--] ..."; +static struct cache_file cache_file; + int main(int argc, char **argv) { int i, force_filename = 0; - struct cache_file cache_file; int newfd = -1; if (read_cache() < 0) { diff --git a/index.c b/index.c ```