# [PATCH] Fix commit_tree() buffer leak

1 messages from 2008-08-11 to 2008-08-11. Participants: Stephan Beyer.
Thread: https://gitlist.dev/t/14943

## Stephan Beyer, 2008-08-11 22:35

Subject: [PATCH] Fix commit_tree() buffer leak
Message-ID: <1218494111-13388-1-git-send-email-s-beyer@gmx.net>
URL: https://gitlist.dev/e/1218494111-13388-1-git-send-email-s-beyer%40gmx.net

```
The commit_tree() strbuf has a minimum size of 8k and it has not been
released yet.  This patch releases the buffer.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
   Hi,

   I haven't checked if there really is some git command that
   calls commit_tree() several times, but for the case and for
   libification's sake this patch seemed useful.

   Regards,
     Stephan

 builtin-commit-tree.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c
index 7a9a309..f773db5 100644
--- a/builtin-commit-tree.c
+++ b/builtin-commit-tree.c
@@ -48,6 +48,7 @@ static const char commit_utf8_warn[] =
 int commit_tree(const char *msg, unsigned char *tree,
 		struct commit_list *parents, unsigned char *ret)
 {
+	int result;
 	int encoding_is_utf8;
 	struct strbuf buffer;
 
@@ -86,7 +87,9 @@ int commit_tree(const char *msg, unsigned char *tree,
 	if (encoding_is_utf8 && !is_utf8(buffer.buf))
 		fprintf(stderr, commit_utf8_warn);
 
-	return write_sha1_file(buffer.buf, buffer.len, commit_type, ret);
+	result = write_sha1_file(buffer.buf, buffer.len, commit_type, ret);
+	strbuf_release(&buffer);
+	return result;
 }
 
 int cmd_commit_tree(int argc, const char **argv, const char *prefix)
-- 
1.6.0.rc2.274.ga7606

```