# [PATCH] Add "--sign" option to git-format-patch-script

5 messages from 2005-08-12 to 2005-08-12. Participants: Johannes Schindelin, Junio C Hamano, Daniel Barkalow.
Thread: https://gitlist.dev/t/1483

## Johannes Schindelin, 2005-08-12 13:32

Subject: [PATCH] Add "--sign" option to git-format-patch-script
Message-ID: <Pine.LNX.4.63.0508121532051.25606@wgmdd8.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0508121532051.25606%40wgmdd8.biozentrum.uni-wuerzburg.de

```
This adds the option "--sign" to git-format-patch-script which adds
a Signed-off-by: line automatically.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

---

 git-format-patch-script |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

a72d370d43c397238a26c1c7f260a3fd6401f4e6
diff --git a/git-format-patch-script b/git-format-patch-script
--- a/git-format-patch-script
+++ b/git-format-patch-script
@@ -6,7 +6,7 @@
 . git-sh-setup-script || die "Not a git archive."
 
 usage () {
-    echo >&2 "usage: $0"' [-n] [-o dir] [--mbox] [--check] [-<diff options>...] upstream [ our-head ]
+    echo >&2 "usage: $0"' [-n] [-o dir] [--mbox] [--check] [--sign] [-<diff options>...] upstream [ our-head ]
 
 Prepare each commit with its patch since our-head forked from upstream,
 one file per patch, for e-mail submission.  Each output file is
@@ -46,6 +46,8 @@ do
     date=t author=t mbox=t ;;
     -n|--n|--nu|--num|--numb|--numbe|--number|--numbere|--numbered)
     numbered=t ;;
+    -s|--s|--si|--sig|--sign)
+    signoff=t ;;
     -o=*|--o=*|--ou=*|--out=*|--outp=*|--outpu=*|--output=*|--output-=*|\
     --output-d=*|--output-di=*|--output-dir=*|--output-dire=*|\
     --output-direc=*|--output-direct=*|--output-directo=*|\
@@ -174,6 +176,14 @@ Date: '"$ad"
 	b body'
 
 	sed -ne "$mailScript" <$commsg
+
+	test "$signoff" = "t" && {
+		offsigner=`git-var GIT_COMMITTER_IDENT | sed -e 's/>.*/>/'`
+		echo
+		echo "Signed-off-by: $offsigner"
+		echo
+	}
+
 	echo '---'
 	echo
 	git-diff-tree -p $diff_opts "$commit" | git-apply --stat --summary

```

## Junio C Hamano, 2005-08-12 15:34

Subject: Re: [PATCH] Add "--sign" option to git-format-patch-script
Message-ID: <7vr7czxj6s.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vr7czxj6s.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <Pine.LNX.4.63.0508121532051.25606@wgmdd8.biozentrum.uni-wuerzburg.de>

```
Good intentions, but I'd rather see these S-O-B lines in the
actual commit objects.  Giving format-patch this option would
discourage people to do so.  Maybe a patch to git commit would
be more appropriate, methinks.

```

## Daniel Barkalow, 2005-08-12 15:56

Subject: Re: [PATCH] Add "--sign" option to git-format-patch-script
Message-ID: <Pine.LNX.4.63.0508121146210.12816@iabervon.org>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0508121146210.12816%40iabervon.org
In-Reply-To: <7vr7czxj6s.fsf@assigned-by-dhcp.cox.net>

```
On Fri, 12 Aug 2005, Junio C Hamano wrote:

> Good intentions, but I'd rather see these S-O-B lines in the
> actual commit objects.  Giving format-patch this option would
> discourage people to do so.  Maybe a patch to git commit would
> be more appropriate, methinks.

Maybe also something in format-patch to check that the commit has one? I, 
at least, tend to have unsigned commits for tracking stuff I've done but 
not cleaned up and signed ones that I want to send off as patches. I've 
confused the branches on occasion, although never when sending stuff, and 
it would be nice to have format-patch tell you if the commit didn't look 
right.

	-Daniel
*This .sig left intentionally blank*

```

## Johannes Schindelin, 2005-08-12 16:05

Subject: Re: [PATCH] Add "--sign" option to git-format-patch-script
Message-ID: <Pine.LNX.4.63.0508121804240.26333@wgmdd8.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0508121804240.26333%40wgmdd8.biozentrum.uni-wuerzburg.de
In-Reply-To: <7vr7czxj6s.fsf@assigned-by-dhcp.cox.net>

```
Hi,

On Fri, 12 Aug 2005, Junio C Hamano wrote:

> Good intentions, but I'd rather see these S-O-B lines in the
> actual commit objects.  Giving format-patch this option would
> discourage people to do so.  Maybe a patch to git commit would
> be more appropriate, methinks.

Maybe in addition to this one? I meant that option to be for on-passers of 
commits they are not author of.

Ciao,
Dscho

```

## Junio C Hamano, 2005-08-12 16:28

Subject: Re: [PATCH] Add "--sign" option to git-format-patch-script
Message-ID: <7v64ubxgp4.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v64ubxgp4.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <Pine.LNX.4.63.0508121804240.26333@wgmdd8.biozentrum.uni-wuerzburg.de>

```
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Fri, 12 Aug 2005, Junio C Hamano wrote:
>
>> Good intentions, but I'd rather see these S-O-B lines in the
>> actual commit objects.  Giving format-patch this option would
>> discourage people to do so.  Maybe a patch to git commit would
>> be more appropriate, methinks.
>
> Maybe in addition to this one? I meant that option to be for on-passers of 
> commits they are not author of.

Surely.  Also I find Daniel's suggestion to check a good one.

```