# extracting to/cc addresses for stg mail 3 messages from 2008-08-01 to 2008-08-05. Participants: Bjorn Helgaas, Karl Hasselström. Thread: https://gitlist.dev/t/14799 ## Bjorn Helgaas, 2008-08-01 22:50 Subject: extracting to/cc addresses for stg mail Message-ID: <200808011650.45915.bjorn.helgaas@hp.com> URL: https://gitlist.dev/e/200808011650.45915.bjorn.helgaas%40hp.com ``` I'm new to stg, so maybe I'm missing the easy way to do this. That said, I'd like to maintain "To:" fields in the patch description, like this: Signed-off-by: Bjorn Helgaas To: Andi Kleen Cc: Andrew Morton "stg mail --auto" takes care of adding Andrew to the Cc list, but I have to manually deal with Andi. I've been doing that by using "stg mail --auto -E" and manually moving the To: line to the top, but that's a hassle. I don't really want to use "stg mail --to=", because then I have to dig out the To: line contents first. I don't really want to use different template files, because I often have one-off self- contained patches that go different places. Is there a way to make stg pay attention to my "To:" lines in the patch description? Or another way to accomplish this? Bjorn ``` ## Karl Hasselström, 2008-08-05 13:39 Subject: Re: extracting to/cc addresses for stg mail Message-ID: <20080805133922.GB29499@diana.vm.bytemark.co.uk> URL: https://gitlist.dev/e/20080805133922.GB29499%40diana.vm.bytemark.co.uk In-Reply-To: <200808011650.45915.bjorn.helgaas@hp.com> ``` On 2008-08-01 16:50:45 -0600, Bjorn Helgaas wrote: > Is there a way to make stg pay attention to my "To:" lines in the > patch description? Or another way to accomplish this? It can't do it at the moment, but it should be easy to fix. In stgit/commands/mail.py, the following lines if options.auto: extra_cc = __get_signers_list(descr) else: extra_cc = [] add the extra CC addresses. You could augment __get_signers_list to return a tuple of to and cc addresses instead of just cc addresses, pass those addesses to the same place extra_cc is fed now, and that's it. If you really hate Python, don't have time, etc., I can do it for you (as long as you agree to test it) -- just ask -- but I try to take every opportunity to get people to contribute patches. :-) -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle ``` ## Bjorn Helgaas, 2008-08-05 17:43 Subject: Re: extracting to/cc addresses for stg mail Message-ID: <200808051143.19683.bjorn.helgaas@hp.com> URL: https://gitlist.dev/e/200808051143.19683.bjorn.helgaas%40hp.com In-Reply-To: <20080805133922.GB29499@diana.vm.bytemark.co.uk> ``` On Tuesday 05 August 2008 07:39:22 am Karl Hasselström wrote: > On 2008-08-01 16:50:45 -0600, Bjorn Helgaas wrote: > > > Is there a way to make stg pay attention to my "To:" lines in the > > patch description? Or another way to accomplish this? > > It can't do it at the moment, but it should be easy to fix. In > stgit/commands/mail.py, the following lines > > if options.auto: > extra_cc = __get_signers_list(descr) > else: > extra_cc = [] > > add the extra CC addresses. You could augment __get_signers_list to > return a tuple of to and cc addresses instead of just cc addresses, > pass those addesses to the same place extra_cc is fed now, and that's > it. > > If you really hate Python, don't have time, etc., I can do it for you > (as long as you agree to test it) -- just ask -- but I try to take > every opportunity to get people to contribute patches. :-) Thanks for the hints. I'll take a look at it. It'll take me a while, but it's a good excuse to try to learn a little Python. Bjorn ```