threads / patch / 14774

patchDo not insert an empty line before the diffstat info

Subject: [StGIT PATCH] Do not insert an empty line before the diffstat info

## tl;dr

3 messages between Jul 31, 2008 and Aug 5, 2008. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Samuel Tardieu· Jul 31, 2008, 12:50 UTC · lore

To make the format of stg output closer to the plain git one, do not insert an empty line between the "---" separator and the diffstat information.

Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
---
 templates/mailattch.tmpl   |    1 -
 templates/patchexport.tmpl |    1 -
 templates/patchmail.tmpl   |    1 -
 3 files changed, 0 insertions(+), 3 deletions(-)

Show changes to 3 files +0 −3

templates/mailattch.tmpl, templates/patchexport.tmpl, templates/patchmail.tmpl

diff --git a/templates/mailattch.tmpl b/templates/mailattch.tmpl
index 430b341..70d2df0 100644
--- a/templates/mailattch.tmpl
+++ b/templates/mailattch.tmpl
@@ -11,7 +11,6 @@ Content-Disposition: inline
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 --MIMEBOUNDARY
 Content-Type: text/plain; name=%(patch)s.patch
diff --git a/templates/patchexport.tmpl b/templates/patchexport.tmpl
index e7f3481..11f2075 100644
--- a/templates/patchexport.tmpl
+++ b/templates/patchexport.tmpl
@@ -4,6 +4,5 @@ From: %(authname)s <%(authemail)s>
 
 %(longdescr)s
 ---
-
 %(diffstat)s
 
diff --git a/templates/patchmail.tmpl b/templates/patchmail.tmpl
index f5c35c2..7d4022a 100644
--- a/templates/patchmail.tmpl
+++ b/templates/patchmail.tmpl
@@ -3,6 +3,5 @@ Subject: [%(prefix)sPATCH%(version)s%(number)s] %(shortdescr)s
 
 %(fromauth)s%(longdescr)s
 ---
-
 %(diffstat)s
 %(diff)s

Karl Hasselström· Aug 4, 2008, 14:20 UTC · re: Samuel Tardieu · lore

Re: [StGIT PATCH] Do not insert an empty line before the diffstat info

On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:

> To make the format of stg output closer to the plain git one, do not
> insert an empty line between the "---" separator and the diffstat
> information.

Thanks, will apply. (IMO it's slightly uglier, but it's better to be consistent. And it does save some space.)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle

Catalin Marinas· Aug 5, 2008, 21:09 UTC · re: Karl Hasselström · lore

Re: [StGIT PATCH] Do not insert an empty line before the diffstat info

2008/8/4 Karl Hasselström <kha@treskal.com>:

Show 8 quoted lines

> On 2008-07-31 14:50:10 +0200, Samuel Tardieu wrote:
>
>> To make the format of stg output closer to the plain git one, do not
>> insert an empty line between the "---" separator and the diffstat
>> information.
>
> Thanks, will apply. (IMO it's slightly uglier, but it's better to be
> consistent. And it does save some space.)

Without this change, I could easily spot people posting patches with StGIT rather than Git :-). Anyway, I'm OK with this patch as well. Thanks.

-- 
Catalin