threads / patch / 14769

patchRemove "git clone" parameters if they are the first in a git clone call

Subject: [FUN PATCH] Remove "git clone" parameters if they are the first in a git clone call

## tl;dr

One message between Jul 30, 2008 and Jul 30, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Pieter de Bie· Jul 30, 2008, 23:02 UTC · lore

This removes accidental duplicate "git clone" parameters, for example when typing:

  git clone git clone git://repo.or.cz/git.git
---

OK, so it happens often to me that I copy a line that already starts with "git clone", and then type it myself again, paste, and hit enter. I thought it might happen to others too, hence this patch.

 builtin-clone.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Show changes to builtin-clone.c +5 −0
diff --git a/builtin-clone.c b/builtin-clone.c
index 4b1ab36..9e4c7c2 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -350,6 +350,11 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 
 	junk_pid = getpid();
 
+	if (argc > 3 && !strcmp(argv[1], "git") && !strcmp(argv[2], "clone")) {
+		argv += 2;
+		argc -= 2;
+	}
+
 	argc = parse_options(argc, argv, builtin_clone_options,
 			     builtin_clone_usage, 0);
 
-- 
1.6.0.rc1.163.g8ec19

← back to recent threads