[JGIT PATCH 1/2] Fix missing packed-refs entries during ref lookup/enumeration

Shawn O. Pearce· Jul 27, 2008, 04:33 UTC · lore

Some codepaths in RefDatabase allowed the caller to lookup a ref without making sure the packed-refs file was loaded into memory. This caused refs which were only packed to appear to not exist, which meant fetch would still try to fetch something we already have had for quite some time.

This resolves the issue I was seeing where `jgit fetch` was always downloading the stable branch of egit.git, even though it has not changed in many weeks.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../src/org/spearce/jgit/lib/RefDatabase.java      |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Show changes to org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java +2 −0

diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java
index 82b995e..98c365e 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java
@@ -115,6 +115,7 @@ class RefDatabase {
 	}
 
 	ObjectId idOf(final String name) throws IOException {
+		refreshPackedRefs();
 		final Ref r = readRefBasic(name, 0);
 		return r != null ? r.getObjectId() : null;
 	}
@@ -132,6 +133,7 @@ class RefDatabase {
 	 *             to the base ref, as the symbolic ref could not be read.
 	 */
 	RefUpdate newUpdate(final String name) throws IOException {
+		refreshPackedRefs();
 		Ref r = readRefBasic(name, 0);
 		if (r == null)
 			r = new Ref(Ref.Storage.NEW, name, null);

-- 
1.6.0.rc0.182.gb96c7

Shawn O. Pearce· Jul 27, 2008, 04:33 UTC · re: Shawn O. Pearce · lore

[JGIT PATCH 2/2] Teach fetch command line a --verbose/-v switch for unchanged refs

We normally don't want to know about unchanged refs, as these are not very interesting. We now skip showing them by default and only produce an output line for unchanged refs if -v is given to us on the command line.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../src/org/spearce/jgit/pgm/Fetch.java            |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

Show changes to org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/Fetch.java +15 −3

diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/Fetch.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/Fetch.java
index 194f669..84b5258 100644
--- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/Fetch.java
+++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/Fetch.java
@@ -40,6 +40,7 @@ package org.spearce.jgit.pgm;
 import java.util.List;
 
 import org.kohsuke.args4j.Argument;
+import org.kohsuke.args4j.Option;
 import org.spearce.jgit.lib.RefUpdate;
 import org.spearce.jgit.lib.TextProgressMonitor;
 import org.spearce.jgit.transport.FetchResult;
@@ -48,6 +49,9 @@ import org.spearce.jgit.transport.TrackingRefUpdate;
 import org.spearce.jgit.transport.Transport;
 
 class Fetch extends TextBuiltin {
+	@Option(name = "--verbose", aliases = { "-v" }, usage = "be more verbose")
+	private boolean verbose;
+
 	@Argument(index = 0, metaVar = "uri-ish")
 	private String remote = "origin";
 
@@ -66,15 +70,23 @@ class Fetch extends TextBuiltin {
 			tn.close();
 		}
 
-		out.print("From ");
-		out.print(tn.getURI());
-		out.println();
+		boolean shownURI = false;
 		for (final TrackingRefUpdate u : r.getTrackingRefUpdates()) {
+			if (!verbose && u.getResult() == RefUpdate.Result.NO_CHANGE)
+				continue;
+
 			final char type = shortTypeOf(u.getResult());
 			final String longType = longTypeOf(u);
 			final String src = abbreviateRef(u.getRemoteName(), false);
 			final String dst = abbreviateRef(u.getLocalName(), true);
 
+			if (!shownURI) {
+				out.print("From ");
+				out.print(tn.getURI());
+				out.println();
+				shownURI = true;
+			}
+
 			out.format(" %c %-17s %-10s -> %s", type, longType, src, dst);
 			out.println();
 		}

-- 
1.6.0.rc0.182.gb96c7

patch, 2 partsFix missing packed-refs entries during ref lookup/enumeration