threads / discuss / 14680

how about removing --exec-path?

Subject: how about removing --exec-path?

## tl;dr

3 messages between Jul 25, 2008 and Jul 26, 2008.

replies: 2people: 3as markdown or json

Alex Riesen· Jul 25, 2008, 09:40 UTC · lore

The thing has at least this problem: is not passed to upload-pack when running fetch. So upload-pack, everything past it gets called either from GIT_EXEC_PATH (which usually is not set) or from builtin exec path (and that's annoying when debugging for instance index-pack).

The feature has a stable alternative ($GIT_EXEC_PATH) anyway.

Or maybe just replace the whole argv_exec_path handling with a plain setenv("GIT_EXEC_PATH", exec_path, 1)?

Johannes Schindelin· Jul 26, 2008, 02:49 UTC · re: Alex Riesen · lore

Re: how about removing --exec-path?

Hi,

On Fri, 25 Jul 2008, Alex Riesen wrote:

> The thing has at least this problem: is not passed to upload-pack when
> running fetch.

It should be added to PATH, and so it is passed to upload-pack, amongst others, in a sense.

Ciao, Dscho

Alex Riesen· Jul 26, 2008, 06:48 UTC · re: Johannes Schindelin · lore

Re: how about removing --exec-path?

Johannes Schindelin, Sat, Jul 26, 2008 04:49:06 +0200:

Show 8 quoted lines

> On Fri, 25 Jul 2008, Alex Riesen wrote:
> 
> > The thing has at least this problem: is not passed to upload-pack when
> > running fetch.
> 
> It should be added to PATH, and so it is passed to upload-pack, amongst 
> others, in a sense.
>

Yes, but next time upload-pack runs a program, it adds builtin exec path to PATH (because --exec-path not given to transport's uploadpack command). So it looks like this:

    $GIT_EXEC_PATH:/usr/local/libexec/git-core:/orig/exec-path:\
    $GIT_EXEC_PATH:/usr/local/libexec/git-core:$ORIG_USER_PATH

which kind of useless for debugging. So using GIT_EXEC_PATH is the only way (and why did we need more? Working around something?)