threads / patch / 14613

patchFix git-svnimport against libsvn_ra.

Subject: [PATCH] Fix git-svnimport against libsvn_ra.

## tl;dr

2 messages between Jul 23, 2008 and Jul 23, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

P. Christeas· Jul 23, 2008, 07:10 UTC · lore

In r27729, libsvn introduced an assert which explicitly forbids searching the tree at "/". Luckily enough, it still accepts an empty string "" as the starting point.

http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra/ra_loader.c?r1=27653&r2=27729
---
 contrib/examples/git-svnimport.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to contrib/examples/git-svnimport.perl +1 −1

diff --git a/contrib/examples/git-svnimport.perl 
b/contrib/examples/git-svnimport.perl
index ea8c1b2..a13bb6a 100755
--- a/contrib/examples/git-svnimport.perl
+++ b/contrib/examples/git-svnimport.perl
@@ -933,7 +933,7 @@ while ($to_rev < $opt_l) {
 	$to_rev = $from_rev + $repack_after;
 	$to_rev = $opt_l if $opt_l < $to_rev;
 	print "Fetching from $from_rev to $to_rev ...\n" if $opt_v;
-	$svn->{'svn'}->get_log("/",$from_rev,$to_rev,0,1,1,\&commit_all);
+	$svn->{'svn'}->get_log("",$from_rev,$to_rev,0,1,1,\&commit_all);
 	my $pid = fork();
 	die "Fork: $!\n" unless defined $pid;
 	unless($pid) {

-- 
1.5.6

Junio C Hamano· Jul 23, 2008, 19:09 UTC · re: P. Christeas · lore

Re: [PATCH] Fix git-svnimport against libsvn_ra.

Thanks.

But the one line description is not descriptive enough, don't you think?

Imagine this line (and nothing else from what you wrote in the body text) appearing among 100 other commits. Can you tell what this commit is about 3 months from now on?

Perhaps:

    svnimport: newer libsvn wants us to ask for the root with "", not "/"

> In r27729, libsvn introduced an assert which explicitly
> forbids searching the tree at "/". Luckily enough, it
> still accepts an empty string "" as the starting point.

I think you implied by saying "still", asking with an empty string had the same effect as asking for the root "/" in earlier versions of SVN, and the patch will not break people with older libsvn. Is that correct?

> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra/ra_loader.c?r1=27653&r2=27729
> ---

Sign-off, please?