# [PATCH] git-submodule: move ill placed shift.

1 messages from 2008-07-21 to 2008-07-21. Participants: Pierre Habouzit.
Thread: https://gitlist.dev/t/14571

## Pierre Habouzit, 2008-07-21 18:15

Subject: [PATCH] git-submodule: move ill placed shift.
Message-ID: <1216664159-2643-1-git-send-email-madcoder@debian.org>
URL: https://gitlist.dev/e/1216664159-2643-1-git-send-email-madcoder%40debian.org

```
When running git submodule update -i, the "-i" is shifted before recursing
into cmd_init and then again outside of the loop. This causes some /bin/sh
to complain about shifting when there are no arguments left (and would
discard anything written after -i too).

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index 9228f56..b40f876 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -264,6 +264,7 @@ cmd_update()
 	do
 		case "$1" in
 		-q|--quiet)
+			shift
 			quiet=1
 			;;
 		-i|--init)
@@ -281,7 +282,6 @@ cmd_update()
 			break
 			;;
 		esac
-		shift
 	done
 
 	git ls-files --stage -- "$@" | grep '^160000 ' |
-- 
1.6.0.rc0.138.g5af7f.dirty

```