threads / patch / 14563

patchEnable threaded delta search on *BSD and Linux.

Subject: [PATCH] Enable threaded delta search on *BSD and Linux.

## tl;dr

3 messages between Jul 21, 2008 and Jul 22, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Pierre Habouzit· Jul 21, 2008, 09:23 UTC · lore

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---

  Following the discussion we had 10 days ago, here is a proposal to enable
  threaded delta search on systems that are likely to behave properly wrt
  memory and CPU usage.

 Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Show changes to Makefile +5 −0

diff --git a/Makefile b/Makefile
index 551bde9..82f89b7 100644
--- a/Makefile
+++ b/Makefile
@@ -565,9 +565,11 @@ EXTLIBS =
 
 ifeq ($(uname_S),Linux)
 	NO_STRLCPY = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),GNU/kFreeBSD)
 	NO_STRLCPY = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),UnixWare)
 	CC = cc
@@ -665,6 +667,7 @@ ifeq ($(uname_S),FreeBSD)
 	BASIC_CFLAGS += -I/usr/local/include
 	BASIC_LDFLAGS += -L/usr/local/lib
 	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),OpenBSD)
 	NO_STRCASESTR = YesPlease
@@ -672,6 +675,7 @@ ifeq ($(uname_S),OpenBSD)
 	NEEDS_LIBICONV = YesPlease
 	BASIC_CFLAGS += -I/usr/local/include
 	BASIC_LDFLAGS += -L/usr/local/lib
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),NetBSD)
 	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)
@@ -680,6 +684,7 @@ ifeq ($(uname_S),NetBSD)
 	BASIC_CFLAGS += -I/usr/pkg/include
 	BASIC_LDFLAGS += -L/usr/pkg/lib
 	ALL_LDFLAGS += -Wl,-rpath,/usr/pkg/lib
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),AIX)
 	NO_STRCASESTR=YesPlease

-- 
1.6.0.rc0.137.g986dd

Junio C Hamano· Jul 22, 2008, 04:54 UTC · re: Pierre Habouzit · lore

Re: [PATCH] Enable threaded delta search on *BSD and Linux.

Pierre Habouzit <madcoder@debian.org> writes:

Show 6 quoted lines

> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>
>   Following the discussion we had 10 days ago, here is a proposal to enable
>   threaded delta search on systems that are likely to behave properly wrt
>   memory and CPU usage.

Hmmm.

I do not want to do this kind of thing very close to the release (like now), but rather immediately after 1.6.0. Will queue for 'next'.

Distro people can decide for themselves and their users, but I am of conservative kind.

Pierre Habouzit· Jul 22, 2008, 06:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] Enable threaded delta search on *BSD and Linux.

On Tue, Jul 22, 2008 at 04:54:14AM +0000, Junio C Hamano wrote:

Show 16 quoted lines

> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> > ---
> >
> >   Following the discussion we had 10 days ago, here is a proposal to enable
> >   threaded delta search on systems that are likely to behave properly wrt
> >   memory and CPU usage.
> 
> Hmmm.
> 
> I do not want to do this kind of thing very close to the release (like
> now), but rather immediately after 1.6.0.  Will queue for 'next'.
> 
> Distro people can decide for themselves and their users, but I am of
> conservative kind.

  makes sense to me.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org