# git-shell build error 5 messages from 2008-07-21 to 2008-07-21. Participants: SungHyun Nam, Stephan Beyer, Johannes Schindelin. Thread: https://gitlist.dev/t/14554 ## SungHyun Nam, 2008-07-21 00:29 Subject: git-shell build error Message-ID: URL: https://gitlist.dev/e/g60la4%24diu%241%40ger.gmane.org ``` Hello, If NO_SETENV is defined, git-shell cannot be built. Simply adding the 'compat/setenv.o' to the make rule fixes the problem. Regards, [master] ~/srcs/git[30]$ LANG= make LINK git-shell Undefined first referenced symbol in file gitsetenv exec_cmd.o ld: fatal: Symbol referencing errors. No output written to git-shell collect2: ld returned 1 exit status make: *** [git-shell] Error 1 ``` ## Stephan Beyer, 2008-07-21 00:43 Subject: [PATCH] Fix git-shell build error when NO_SETENV is defined Message-ID: <1216601017-7871-1-git-send-email-s-beyer@gmx.net> URL: https://gitlist.dev/e/1216601017-7871-1-git-send-email-s-beyer%40gmx.net In-Reply-To: ``` If NO_SETENV is defined, git-shell could not be built. Thanks to SungHyun Nam for the hint. Signed-off-by: Stephan Beyer --- This was my mistake. I haven't tested with several build options. Now I've tested with NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1 NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1 and compat/setenv.o seems to be the only one that was missing. Regards. Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 2b670d7..b650ee6 100644 --- a/Makefile +++ b/Makefile @@ -1203,7 +1203,8 @@ git-http-push$X: revision.o http.o http-push.o $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \ $(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT) -git-shell$X: compat/strlcpy.o abspath.o ctype.o exec_cmd.o quote.o strbuf.o usage.o wrapper.o shell.o +git-shell$X: compat/strlcpy.o compat/setenv.o abspath.o ctype.o exec_cmd.o \ + quote.o strbuf.o usage.o wrapper.o shell.o $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIB_OBJS) $(BUILTIN_OBJS): $(LIB_H) -- 1.5.6.3.390.g7b30 ``` ## Johannes Schindelin, 2008-07-21 01:23 Subject: Re: [PATCH] Fix git-shell build error when NO_SETENV is defined Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0807210321190.3305%40eeepc-johanness In-Reply-To: <1216601017-7871-1-git-send-email-s-beyer@gmx.net> ``` Hi, On Mon, 21 Jul 2008, Stephan Beyer wrote: > If NO_SETENV is defined, git-shell could not be built. > > Thanks to SungHyun Nam for the hint. > > Signed-off-by: Stephan Beyer > --- > > This was my mistake. I haven't tested with several build options. > Now I've tested with > NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1 > NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1 > and compat/setenv.o seems to be the only one that was missing. Funny. It was not 24 hours ago that Hannes reported a related issue. And he was testing with different options. His fix to include COMPAT_OBJECTS made much more sense, too, than to pick selectively a file here and a file there and then hoping that you catch all. Ciao, Dscho ``` ## Stephan Beyer, 2008-07-21 01:29 Subject: Re: [PATCH] Fix git-shell build error when NO_SETENV is defined Message-ID: <20080721012928.GG5950@leksak.fem-net> URL: https://gitlist.dev/e/20080721012928.GG5950%40leksak.fem-net In-Reply-To: ``` Johannes Schindelin wrote: > Funny. It was not 24 hours ago that Hannes reported a related issue. And > he was testing with different options. Oh, seems that I have missed that topic. Gna :) But fine if everything is working again then. Regards. -- Stephan Beyer , PGP 0x6EDDD207FCC5040F ``` ## Johannes Schindelin, 2008-07-21 01:33 Subject: Re: [PATCH] Fix git-shell build error when NO_SETENV is defined Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0807210333330.3305%40eeepc-johanness In-Reply-To: <20080721012928.GG5950@leksak.fem-net> ``` Hi, On Mon, 21 Jul 2008, Stephan Beyer wrote: > Johannes Schindelin wrote: > > Funny. It was not 24 hours ago that Hannes reported a related issue. And > > he was testing with different options. > > Oh, seems that I have missed that topic. Gna :) > > But fine if everything is working again then. No, it is not. Ciao, Dscho ```