# [PATCH] builtin-merge.c: Fix option parsing 2 messages from 2008-07-20 to 2008-07-20. Participants: Michele Ballabio, Miklos Vajna. Thread: https://gitlist.dev/t/14547 ## Michele Ballabio, 2008-07-20 12:34 Subject: [PATCH] builtin-merge.c: Fix option parsing Message-ID: <200807201434.47545.barra_cuda@katamail.com> URL: https://gitlist.dev/e/200807201434.47545.barra_cuda%40katamail.com ``` Now "git merge -m" needs a message, and errors out with the usage text if none is given. This way, t7600-merge.sh is fixed. Signed-off-by: Michele Ballabio --- builtin-merge.c | 5 +++-- t/t7600-merge.sh | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/builtin-merge.c b/builtin-merge.c index 129b4e6..84a541d 100644 --- a/builtin-merge.c +++ b/builtin-merge.c @@ -68,10 +68,11 @@ static int option_parse_message(const struct option *opt, if (unset) strbuf_setlen(buf, 0); - else { + else if (arg) { strbuf_addf(buf, "%s\n\n", arg); have_message = 1; - } + } else + return error("switch `m' requires a value"); return 0; } diff --git a/t/t7600-merge.sh b/t/t7600-merge.sh index 26cf8dc..5eeb6c2 100755 --- a/t/t7600-merge.sh +++ b/t/t7600-merge.sh @@ -221,7 +221,7 @@ test_expect_success 'setup' ' test_debug 'gitk --all' -test_expect_failure 'test option parsing' ' +test_expect_success 'test option parsing' ' test_must_fail git merge -$ c1 && test_must_fail git merge --no-such c1 && test_must_fail git merge -s foobar c1 && -- 1.5.6.3 ``` ## Miklos Vajna, 2008-07-20 13:08 Subject: Re: [PATCH] builtin-merge.c: Fix option parsing Message-ID: <20080720130825.GG10347@genesis.frugalware.org> URL: https://gitlist.dev/e/20080720130825.GG10347%40genesis.frugalware.org In-Reply-To: <200807201434.47545.barra_cuda@katamail.com> ``` On Sun, Jul 20, 2008 at 02:34:47PM +0200, Michele Ballabio wrote: > Now "git merge -m" needs a message, and errors out with the usage > text if none is given. > This way, t7600-merge.sh is fixed. Thanks, I was about to fix this, but you were faster. ;-) ```