# [PATCH] guilt(1): fix path to git-sh-setup 4 messages from 2008-07-16 to 2008-07-17. Participants: Alex Chiang, Petr Baudis, Johannes Schindelin, Josef 'Jeff' Sipek. Thread: https://gitlist.dev/t/14499 ## Alex Chiang, 2008-07-16 23:23 Subject: [PATCH] guilt(1): fix path to git-sh-setup Message-ID: <20080716232339.GC22919@ldl.fc.hp.com> URL: https://gitlist.dev/e/20080716232339.GC22919%40ldl.fc.hp.com ``` git is in the process of moving subcommands to /usr/libexec/git-core This move breaks an assumption in guilt about the location of git-sh-setup. We can ask git for where it thinks its executables live. Signed-off-by: Alex Chiang --- diff --git a/guilt b/guilt index 50414a4..ba4593a 100755 --- a/guilt +++ b/guilt @@ -23,7 +23,7 @@ esac # we change directories ourselves SUBDIRECTORY_OK=1 -. git-sh-setup +. `git --exec-path`/git-sh-setup # # Git version check ``` ## Petr Baudis, 2008-07-17 10:02 Subject: Re: [PATCH] guilt(1): fix path to git-sh-setup Message-ID: <20080717100217.GT32184@machine.or.cz> URL: https://gitlist.dev/e/20080717100217.GT32184%40machine.or.cz In-Reply-To: <20080716232339.GC22919@ldl.fc.hp.com> ``` On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote: > diff --git a/guilt b/guilt > index 50414a4..ba4593a 100755 > --- a/guilt > +++ b/guilt > @@ -23,7 +23,7 @@ esac > # we change directories ourselves > SUBDIRECTORY_OK=1 > > -. git-sh-setup > +. `git --exec-path`/git-sh-setup Beware of the proverbial "/Program Files/Git" location, however. Petr "Pasky" Baudis ``` ## Johannes Schindelin, 2008-07-17 11:58 Subject: Re: [PATCH] guilt(1): fix path to git-sh-setup Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0807171357150.3486%40wbgn129.biozentrum.uni-wuerzburg.de In-Reply-To: <20080717100217.GT32184@machine.or.cz> ``` Hi, On Thu, 17 Jul 2008, Petr Baudis wrote: > On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote: > > diff --git a/guilt b/guilt > > index 50414a4..ba4593a 100755 > > --- a/guilt > > +++ b/guilt > > @@ -23,7 +23,7 @@ esac > > # we change directories ourselves > > SUBDIRECTORY_OK=1 > > > > -. git-sh-setup > > +. `git --exec-path`/git-sh-setup > > Beware of the proverbial "/Program Files/Git" location, however. Indeed. And when trying to stray not _too_ far away from the coding style of git.git, avoid the backticks, too, like so: . "$(git --exec-path)"/git-sh-setup Ciao, Dscho ``` ## Josef 'Jeff' Sipek, 2008-07-17 14:53 Subject: Re: [PATCH] guilt(1): fix path to git-sh-setup Message-ID: <20080717145356.GA7235@josefsipek.net> URL: https://gitlist.dev/e/20080717145356.GA7235%40josefsipek.net In-Reply-To: <20080716232339.GC22919@ldl.fc.hp.com> ``` On Wed, Jul 16, 2008 at 05:23:39PM -0600, Alex Chiang wrote: > git is in the process of moving subcommands to /usr/libexec/git-core > > This move breaks an assumption in guilt about the location of > git-sh-setup. I already have a fix for this queued up. Thanks anyway, Josef 'Jeff' Sipek. P.S. Pasky: good catch, I'll check the queued up patch to make sure it's not "broken" -- In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. - Linus Torvalds ```