threads / patch / 14444

patchbash: Add long option completion for 'git send-email'

Subject: [PATCH] bash: Add long option completion for 'git send-email'

## tl;dr

6 messages between Jul 14, 2008 and Jul 15, 2008. Diffs are folded; open one to read it.

replies: 5people: 3as markdown or json

Teemu Likonen· Jul 14, 2008, 08:21 UTC · lore
Add the following long options to be completed with 'git send-email':
    --bcc --cc --cc-cmd --chain-reply-to --compose --dry-run
    --envelope-sender --from --identity --in-reply-to
    --no-chain-reply-to --no-signed-off-by-cc --no-suppress-from
    --no-thread --quiet --signed-off-by-cc --smtp-pass --smtp-server
    --smtp-server-port --smtp-ssl --smtp-user --subject --suppress-cc
    --suppress-from --thread --to

Short ones like --to and --cc are not usable for actual completion because of the shortness itself and because there are longer ones which start with same letters (--thread, --compose). It's still useful to have these shorter options _listed_ when user presses TAB key after typing two dashes. It gives user an idea what options are available (and --to and --cc are probably the most commonly used).

Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
---
 contrib/completion/git-completion.bash |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
Show changes to contrib/completion/git-completion.bash +20 −0
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d268e6f..b15f3a9 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -905,6 +905,24 @@ _git_rebase ()
 	__gitcomp "$(__git_refs)"
 }
 
+_git_send_email ()
+{
+	local cur="${COMP_WORDS[COMP_CWORD]}"
+	case "$cur" in
+	--*)
+		__gitcomp "--bcc --cc --cc-cmd --chain-reply-to --compose
+			--dry-run --envelope-sender --from --identity
+			--in-reply-to --no-chain-reply-to --no-signed-off-by-cc
+			--no-suppress-from --no-thread --quiet
+			--signed-off-by-cc --smtp-pass --smtp-server
+			--smtp-server-port --smtp-ssl --smtp-user --subject
+			--suppress-cc --suppress-from --thread --to"
+		return
+		;;
+	esac
+	__git_complete_file
+}
+
 _git_config ()
 {
 	local cur="${COMP_WORDS[COMP_CWORD]}"
@@ -1376,6 +1394,7 @@ _git ()
 	rebase)      _git_rebase ;;
 	remote)      _git_remote ;;
 	reset)       _git_reset ;;
+	send-email)  _git_send_email ;;
 	shortlog)    _git_shortlog ;;
 	show)        _git_show ;;
 	show-branch) _git_log ;;
@@ -1435,6 +1454,7 @@ complete -o default -o nospace -F _git_rebase git-rebase
 complete -o default -o nospace -F _git_config git-config
 complete -o default -o nospace -F _git_remote git-remote
 complete -o default -o nospace -F _git_reset git-reset
+complete -o default -o nospace -F _git_send_email git-send-email
 complete -o default -o nospace -F _git_shortlog git-shortlog
 complete -o default -o nospace -F _git_show git-show
 complete -o default -o nospace -F _git_stash git-stash

-- 
1.5.6.3.316.g01fc
Shawn O. Pearce· Jul 15, 2008, 04:38 UTC · re: Teemu Likonen · lore

Re: [PATCH] bash: Add long option completion for 'git send-email'

Teemu Likonen <tlikonen@iki.fi> wrote:
> Add the following long options to be completed with 'git send-email':
...
> Short ones like --to and --cc are not usable for actual completion
I agree, these are worth including.
Show 24 quoted lines
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d268e6f..b15f3a9 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -905,6 +905,24 @@ _git_rebase ()
>  	__gitcomp "$(__git_refs)"
>  }
>  
> +_git_send_email ()
> +{
> +	local cur="${COMP_WORDS[COMP_CWORD]}"
> +	case "$cur" in
> +	--*)
> +		__gitcomp "--bcc --cc --cc-cmd --chain-reply-to --compose
> +			--dry-run --envelope-sender --from --identity
> +			--in-reply-to --no-chain-reply-to --no-signed-off-by-cc
> +			--no-suppress-from --no-thread --quiet
> +			--signed-off-by-cc --smtp-pass --smtp-server
> +			--smtp-server-port --smtp-ssl --smtp-user --subject
> +			--suppress-cc --suppress-from --thread --to"
> +		return
> +		;;
> +	esac
> +	__git_complete_file

Don't use __git_complete_file here. As far as I remember, git-send-email does not accept "origin/maint:some.patch" as an email to extract from Git prior to sending. It looks for files in the local filesystem. So you want standard bash completion for anything not starting with --.

Just use COMPREPLY=() at the end.  See _git_am for an example.
Show 8 quoted lines
> @@ -1435,6 +1454,7 @@ complete -o default -o nospace -F _git_rebase git-rebase
>  complete -o default -o nospace -F _git_config git-config
>  complete -o default -o nospace -F _git_remote git-remote
>  complete -o default -o nospace -F _git_reset git-reset
> +complete -o default -o nospace -F _git_send_email git-send-email
>  complete -o default -o nospace -F _git_shortlog git-shortlog
>  complete -o default -o nospace -F _git_show git-show
>  complete -o default -o nospace -F _git_stash git-stash
Hmm.  With dash form commands gone in 1.6 we should remove these.

But I suspect this completion patch could be shipped in the next 1.5.6 maint release as its really quite trivial. Junio, any comment on that?

-- 
Shawn.
Junio C Hamano· Jul 15, 2008, 04:49 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] bash: Add long option completion for 'git send-email'

"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 5 quoted lines
> Hmm.  With dash form commands gone in 1.6 we should remove these.
>
> But I suspect this completion patch could be shipped in the next
> 1.5.6 maint release as its really quite trivial.  Junio, any comment
> on that?

Yeah, it is trivial but does it deserve "bugfix -- we need to deliver this change to the end users, otherwise they will suffer" label? Probably not.

Shawn O. Pearce· Jul 15, 2008, 04:58 UTC · re: Junio C Hamano · lore

Re: [PATCH] bash: Add long option completion for 'git send-email'

Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Hmm.  With dash form commands gone in 1.6 we should remove these.
> >
> > But I suspect this completion patch could be shipped in the next
> > 1.5.6 maint release as its really quite trivial.  Junio, any comment
> > on that?
> 
> Yeah, it is trivial but does it deserve "bugfix -- we need to deliver this
> change to the end users, otherwise they will suffer" label?  Probably not.

Not really, but we have shipped new completion functionality (missing --graph option to git-log) in maint releases in recent history.

If it was me maintaining git.git, I'd probably toss this into maint. But I think I have a more aggressive personality than you, and am more willing to take a risk. Users frequently don't like such risk.

I defer to your wise judgement. Given prior statements about what goes where, you are being consistent to say this should go in 1.6. In which case I suggest Teemu should drop that last hunk as we should really drop that entire block of code from the script.

-- 
Shawn.
Teemu Likonen· Jul 15, 2008, 06:30 UTC · re: Shawn O. Pearce · lore

[PATCH v2] bash: Teach the bash completion about 'git send-email'

Add the following long options to be completed with 'git send-email':
    --bcc --cc --cc-cmd --chain-reply-to --compose --dry-run
    --envelope-sender --from --identity --in-reply-to
    --no-chain-reply-to --no-signed-off-by-cc --no-suppress-from
    --no-thread --quiet --signed-off-by-cc --smtp-pass --smtp-server
    --smtp-server-port --smtp-ssl --smtp-user --subject --suppress-cc
    --suppress-from --thread --to

Short ones like --to and --cc are not usable for actual completion because of the shortness itself and because there are longer ones which start with same letters (--thread, --compose). It's still useful to have these shorter options _listed_ when user presses TAB key after typing two dashes. It gives user an idea what options are available (and --to and --cc are probably the most commonly used).

Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
---
Shawn O. Pearce wrote (2008-07-15 04:38 +0000):
Show 7 quoted lines
> Don't use __git_complete_file here.  As far as I remember,
> git-send-email does not accept "origin/maint:some.patch" as an email
> to extract from Git prior to sending.  It looks for files in the local
> filesystem.  So you want standard bash completion for anything not
> starting with --.
> 
> Just use COMPREPLY=() at the end.  See _git_am for an example.
Done. And thanks.
> > +complete -o default -o nospace -F _git_send_email git-send-email
Show 5 quoted lines
> Hmm.  With dash form commands gone in 1.6 we should remove these.
> 
> But I suspect this completion patch could be shipped in the next 1.5.6
> maint release as its really quite trivial.  Junio, any comment on
> that?

This is a for-1.6 version so the completion for dashed command (git-send-email) is dropped. I see Shawn already sent a patch which drops all those.

 contrib/completion/git-completion.bash |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)
Show changes to contrib/completion/git-completion.bash +19 −0
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d268e6f..48ebbf7 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -905,6 +905,24 @@ _git_rebase ()
 	__gitcomp "$(__git_refs)"
 }
 
+_git_send_email ()
+{
+	local cur="${COMP_WORDS[COMP_CWORD]}"
+	case "$cur" in
+	--*)
+		__gitcomp "--bcc --cc --cc-cmd --chain-reply-to --compose
+			--dry-run --envelope-sender --from --identity
+			--in-reply-to --no-chain-reply-to --no-signed-off-by-cc
+			--no-suppress-from --no-thread --quiet
+			--signed-off-by-cc --smtp-pass --smtp-server
+			--smtp-server-port --smtp-ssl --smtp-user --subject
+			--suppress-cc --suppress-from --thread --to"
+		return
+		;;
+	esac
+	COMPREPLY=()
+}
+
 _git_config ()
 {
 	local cur="${COMP_WORDS[COMP_CWORD]}"
@@ -1376,6 +1394,7 @@ _git ()
 	rebase)      _git_rebase ;;
 	remote)      _git_remote ;;
 	reset)       _git_reset ;;
+	send-email)  _git_send_email ;;
 	shortlog)    _git_shortlog ;;
 	show)        _git_show ;;
 	show-branch) _git_log ;;

-- 
1.5.6.3.316.g01fc
Shawn O. Pearce· Jul 15, 2008, 06:31 UTC · re: Teemu Likonen · lore

Re: [PATCH v2] bash: Teach the bash completion about 'git send-email'

Teemu Likonen <tlikonen@iki.fi> wrote:
Show 17 quoted lines
> Add the following long options to be completed with 'git send-email':
> 
>     --bcc --cc --cc-cmd --chain-reply-to --compose --dry-run
>     --envelope-sender --from --identity --in-reply-to
>     --no-chain-reply-to --no-signed-off-by-cc --no-suppress-from
>     --no-thread --quiet --signed-off-by-cc --smtp-pass --smtp-server
>     --smtp-server-port --smtp-ssl --smtp-user --subject --suppress-cc
>     --suppress-from --thread --to
> 
> Short ones like --to and --cc are not usable for actual completion
> because of the shortness itself and because there are longer ones which
> start with same letters (--thread, --compose). It's still useful to have
> these shorter options _listed_ when user presses TAB key after typing
> two dashes. It gives user an idea what options are available (and --to
> and --cc are probably the most commonly used).
> 
> Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Thanks for the quick reply cleaning up the minor details.  :)
Show 69 quoted lines
> Shawn O. Pearce wrote (2008-07-15 04:38 +0000):
> 
> > Don't use __git_complete_file here.  As far as I remember,
> > git-send-email does not accept "origin/maint:some.patch" as an email
> > to extract from Git prior to sending.  It looks for files in the local
> > filesystem.  So you want standard bash completion for anything not
> > starting with --.
> > 
> > Just use COMPREPLY=() at the end.  See _git_am for an example.
> 
> Done. And thanks.
> 
> > > +complete -o default -o nospace -F _git_send_email git-send-email
> 
> > Hmm.  With dash form commands gone in 1.6 we should remove these.
> > 
> > But I suspect this completion patch could be shipped in the next 1.5.6
> > maint release as its really quite trivial.  Junio, any comment on
> > that?
> 
> This is a for-1.6 version so the completion for dashed command
> (git-send-email) is dropped. I see Shawn already sent a patch which
> drops all those.
> 
> 
> 
>  contrib/completion/git-completion.bash |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d268e6f..48ebbf7 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -905,6 +905,24 @@ _git_rebase ()
>  	__gitcomp "$(__git_refs)"
>  }
>  
> +_git_send_email ()
> +{
> +	local cur="${COMP_WORDS[COMP_CWORD]}"
> +	case "$cur" in
> +	--*)
> +		__gitcomp "--bcc --cc --cc-cmd --chain-reply-to --compose
> +			--dry-run --envelope-sender --from --identity
> +			--in-reply-to --no-chain-reply-to --no-signed-off-by-cc
> +			--no-suppress-from --no-thread --quiet
> +			--signed-off-by-cc --smtp-pass --smtp-server
> +			--smtp-server-port --smtp-ssl --smtp-user --subject
> +			--suppress-cc --suppress-from --thread --to"
> +		return
> +		;;
> +	esac
> +	COMPREPLY=()
> +}
> +
>  _git_config ()
>  {
>  	local cur="${COMP_WORDS[COMP_CWORD]}"
> @@ -1376,6 +1394,7 @@ _git ()
>  	rebase)      _git_rebase ;;
>  	remote)      _git_remote ;;
>  	reset)       _git_reset ;;
> +	send-email)  _git_send_email ;;
>  	shortlog)    _git_shortlog ;;
>  	show)        _git_show ;;
>  	show-branch) _git_log ;;
> -- 
> 1.5.6.3.316.g01fc
> 
-- 
Shawn.

← back to recent threads