# [PATCH] git-submodule - Fix bugs in adding an existing repo as a module

1 messages from 2008-07-08 to 2008-07-08. Participants: Mark Levedahl.
Thread: https://gitlist.dev/t/14335

## Mark Levedahl, 2008-07-08 02:36

Subject: [PATCH] git-submodule - Fix bugs in adding an existing repo as a module
Message-ID: <1215484600-2660-1-git-send-email-mlevedahl@gmail.com>
URL: https://gitlist.dev/e/1215484600-2660-1-git-send-email-mlevedahl%40gmail.com

```
git-submodule add would trip if path to the submodule included a space,
or if its .git was a gitdir: link to a GIT_DIR kept elsewhere. Fix both.

Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
 git-submodule.sh |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index 3eb78cc..099a7d7 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -167,8 +167,7 @@ cmd_add()
 	# perhaps the path exists and is already a git repo, else clone it
 	if test -e "$path"
 	then
-		if test -d "$path/.git" &&
-		test "$(unset GIT_DIR; cd $path; git rev-parse --git-dir)" = ".git"
+		if test -d "$path"/.git -o -f "$path"/.git
 		then
 			echo "Adding existing repo at '$path' to the index"
 		else
-- 
1.5.6.2.271.g73ad8

```