# [PATCH] Add 'git-p4.allowSubmit' to git-p4 3 messages from 2008-06-22 to 2008-06-26. Participants: Jing Xue, Simon Hausmann, Junio C Hamano. Thread: https://gitlist.dev/t/14086 ## Jing Xue, 2008-06-22 18:12 Subject: [PATCH] Add 'git-p4.allowSubmit' to git-p4 Message-ID: <20080622181239.GA1855@jabba.hq.digizenstudio.com> URL: https://gitlist.dev/e/20080622181239.GA1855%40jabba.hq.digizenstudio.com ``` I'm working with a perforce repo using git-p4. There are some config files which I need to change locally according to my environment. I'm using a 'local' git branch to park these changes. And I want to avoid accidentally checking them into p4 just by doing "git p4 submit" mindlessly without realizing which branch I'm actually on. This patch adds a new git config, 'git-p4.allowSubmit', which is a whitelist of branch names. "git p4 submit" will only allow submissions from local branches on the list. Useful for preventing inadvertently submitting from a strictly local branch. For backward compatibility, if this config is not set at all, submissions from all branches are allowed. Signed-off-by: Jing Xue --- contrib/fast-import/git-p4 | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index d8de9f6..87ca51e 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -687,6 +687,10 @@ class P4Submit(Command): else: return False + allowSubmit = gitConfig("git-p4.allowSubmit") + if len(allowSubmit) > 0 and not self.master in allowSubmit.split(","): + die("%s is not in git-p4.allowSubmit" % self.master) + [upstream, settings] = findUpstreamBranchPoint() self.depotPath = settings['depot-paths'][0] if len(self.origin) == 0: -- 1.5.6.13.g2ae4ef ``` ## Simon Hausmann, 2008-06-26 18:42 Subject: Re: [PATCH] Add 'git-p4.allowSubmit' to git-p4 Message-ID: <200806262042.13121.simon@lst.de> URL: https://gitlist.dev/e/200806262042.13121.simon%40lst.de In-Reply-To: <20080622181239.GA1855@jabba.hq.digizenstudio.com> ``` On Sunday 22 June 2008 20:12:39 Jing Xue wrote: > I'm working with a perforce repo using git-p4. There are some config > files which I need to change locally according to my environment. I'm > using a 'local' git branch to park these changes. And I want to avoid > accidentally checking them into p4 just by doing "git p4 submit" > mindlessly without realizing which branch I'm actually on. > > This patch adds a new git config, 'git-p4.allowSubmit', which is a > whitelist of branch names. "git p4 submit" will only allow submissions > from local branches on the list. Useful for preventing inadvertently > submitting from a strictly local branch. > > For backward compatibility, if this config is not set at all, > submissions from all branches are allowed. > > Signed-off-by: Jing Xue Acked-By: Simon Hausmann Simon > contrib/fast-import/git-p4 | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 > index d8de9f6..87ca51e 100755 > --- a/contrib/fast-import/git-p4 > +++ b/contrib/fast-import/git-p4 > @@ -687,6 +687,10 @@ class P4Submit(Command): > else: > return False > > + allowSubmit = gitConfig("git-p4.allowSubmit") > + if len(allowSubmit) > 0 and not self.master in > allowSubmit.split(","): + die("%s is not in git-p4.allowSubmit" > % self.master) > + > [upstream, settings] = findUpstreamBranchPoint() > self.depotPath = settings['depot-paths'][0] > if len(self.origin) == 0: ``` ## Junio C Hamano, 2008-06-26 19:10 Subject: Re: [PATCH] Add 'git-p4.allowSubmit' to git-p4 Message-ID: <7v7iccqafa.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v7iccqafa.fsf%40gitster.siamese.dyndns.org In-Reply-To: <200806262042.13121.simon@lst.de> ``` Thanks, both. ```