# [JGIT] fnmatch Implementation.

2 messages from 2008-06-18 to 2008-06-18. Participants: Florian Köberle, Robin Rosenberg.
Thread: https://gitlist.dev/t/14011

## Florian Köberle, 2008-06-18 10:12

Subject: [JGIT] fnmatch Implementation.
Message-ID: <4858DFA2.30203@web.de>
URL: https://gitlist.dev/e/4858DFA2.30203%40web.de

```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

when I send a large list of patches and one is wrong then you don't
accept any. That's why I now will try to get one patch in before I send
the next one.

The first patch I will commit this way is the fnmatch patch.

As suggested by Robin I replaced unicode characters not included in the
ASCII set with \uXXXX sequences.

I also added some more test cases and improved the javadoc of the
FileNameMatcher class.

Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIWN+i59ca4mzhfxMRAu8oAJ44Vjp0jvzfjRPRqVoDsUyypNVbvQCgoZRX
GK9kaAlh+Zu3nFen30tc7Rc=
=pvuB
-----END PGP SIGNATURE-----

```

## Robin Rosenberg, 2008-06-18 18:43

Subject: Re: [JGIT] fnmatch Implementation.
Message-ID: <200806182043.43321.robin.rosenberg.lists@dewire.com>
URL: https://gitlist.dev/e/200806182043.43321.robin.rosenberg.lists%40dewire.com
In-Reply-To: <4858DFA2.30203@web.de>

```
onsdagen den 18 juni 2008 12.12.50 skrev Florian Köberle:
> Hi,
> 
> when I send a large list of patches and one is wrong then you don't
> accept any. That's why I now will try to get one patch in before I send
> the next one.
Patience please. When there is long series it *will* take time for
a number of reasons. Most have nothing to do with this project at all. But in
general you will  find a short patch series  *much* easier to get through than 
a long one.

If you think my grouping is ok, then ack and I can commit from there. I
was thinking of actually adding some test myself, but that's all I had in mind.

> The first patch I will commit this way is the fnmatch patch.
> 
> As suggested by Robin I replaced unicode characters not included in the
> ASCII set with \uXXXX sequences.
> 
> I also added some more test cases and improved the javadoc of the
> FileNameMatcher class.
That's good.

> 
> Best regards,
> Florian
>

```