threads / patch / 1395

patchlist shortlog items in commit order

Subject: [patch] list shortlog items in commit order

## tl;dr

5 messages between Aug 2, 2005 and Aug 3, 2005. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

Nicolas Pitre· Aug 2, 2005, 21:18 UTC · lore

The current shortlog list is backward making it look odd. This reverses it so things appear more logically.

Signed-off-by: Nicolas Pitre <nico@cam.org>

Show changes to git-shortlog +1 −1

diff --git a/git-shortlog b/git-shortlog
--- a/git-shortlog
+++ b/git-shortlog
@@ -90,7 +90,7 @@ sub shortlog_output {
 
 		# output author's 1-line summaries
 		$obj = $map{$key};
-		foreach $desc (@$obj) {
+		foreach $desc (reverse @$obj) {
 			print "  $desc\n";
 			$n_output++;
 		}

Junio C Hamano· Aug 2, 2005, 22:34 UTC · re: Nicolas Pitre · lore

Re: [patch] list shortlog items in commit order

Nicolas Pitre <nico@cam.org> writes:

> The current shortlog list is backward making it look odd.
> This reverses it so things appear more logically.

Sorry, I do not know how the shortlog looked like in BK days, but it would be nice to match that order. I do not have preference either way myself.

I'll let it simmer and let the list decide, but I think the kernel folks care the most about this one, so I am asking the original authors, Linus and Jeff, if they want to go for it, or veto it.

Nicolas Pitre· Aug 2, 2005, 22:41 UTC · re: Junio C Hamano · lore

Re: [patch] list shortlog items in commit order

On Tue, 2 Aug 2005, Junio C Hamano wrote:

Show 7 quoted lines

> Nicolas Pitre <nico@cam.org> writes:
> 
> > The current shortlog list is backward making it look odd.
> > This reverses it so things appear more logically.
> 
> Sorry, I do not know how the shortlog looked like in BK days,
> but it would be nice to match that order.

This is precisely why I made this patch: to make it look like the BK shortlog.

Nicolas

Jeff Garzik· Aug 3, 2005, 03:58 UTC · re: Junio C Hamano · lore

Re: [patch] list shortlog items in commit order

Junio C Hamano wrote:

Show 15 quoted lines

> Nicolas Pitre <nico@cam.org> writes:
> 
> 
>>The current shortlog list is backward making it look odd.
>>This reverses it so things appear more logically.
> 
> 
> Sorry, I do not know how the shortlog looked like in BK days,
> but it would be nice to match that order.  I do not have
> preference either way myself.
> 
> I'll let it simmer and let the list decide, but I think the
> kernel folks care the most about this one, so I am asking the
> original authors, Linus and Jeff, if they want to go for it, or
> veto it.

<shrug>  I don't really care either way.

	Jeff

Linus Torvalds· Aug 3, 2005, 04:59 UTC · re: Jeff Garzik · lore

Re: [patch] list shortlog items in commit order

On Tue, 2 Aug 2005, Jeff Garzik wrote:

> 
> <shrug>  I don't really care either way.

I suspect it's mostly the users, not the developers, who care. The core developers already know what went in, and have git to see it, they don't look at the shortlog output. So I suspect it's more important to see if there's user feedback one way or the other..

		Linus