threads / patch / 1373

patchadd NO_CURL option to the Makefile

Subject: [PATCH] add NO_CURL option to the Makefile

## tl;dr

3 messages between Jul 31, 2005 and Jul 31, 2005. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Johannes Schindelin· Jul 31, 2005, 00:14 UTC · lore

This patch implements Linus' idea that if you are not interested in pulling by HTTP, you can now say

	NO_CURL=1 make

to compile everything except git-http-pull (thus not needing curl at all). ---

 Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

b2e1e7eb6876b5f385bc52bf78e9551d1457215b

Show changes to Makefile +5 −1

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -69,7 +69,7 @@ PROG=   git-update-cache git-diff-files
 	git-checkout-cache git-diff-tree git-rev-tree git-ls-files \
 	git-check-files git-ls-tree git-merge-base git-merge-cache \
 	git-unpack-file git-export git-diff-cache git-convert-cache \
-	git-http-pull git-ssh-push git-ssh-pull git-rev-list git-mktag \
+	git-ssh-push git-ssh-pull git-rev-list git-mktag \
 	git-diff-helper git-tar-tree git-local-pull git-hash-object \
 	git-get-tar-commit-id git-apply git-stripspace \
 	git-diff-stages git-rev-parse git-patch-id git-pack-objects \
@@ -78,6 +78,10 @@ PROG=   git-update-cache git-diff-files
 	git-show-index git-daemon git-var git-peek-remote \
 	git-update-server-info git-show-rev-cache git-build-rev-cache

+ifndef NO_CURL
+PROG+= git-http-pull
+endif
+
 LIB_FILE=libgit.a
 LIB_H=cache.h object.h blob.h tree.h commit.h tag.h delta.h epoch.h csum-file.h \
 	pack.h pkt-line.h refs.h

Junio C Hamano· Jul 31, 2005, 01:09 UTC · re: Johannes Schindelin · lore

Re: [PATCH] add NO_CURL option to the Makefile

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 6 quoted lines

> This patch implements Linus' idea that if you are not interested in
> pulling by HTTP, you can now say
>
> 	NO_CURL=1 make
>
> to compile everything except git-http-pull (thus not needing curl at all).

Thanks. Obviously this does not take care of the use of curl executable to handle http:// URL in clone and fetch, but I do not think that is worth the trouble (we should document it though).

I love it I can just slow down and let others submit obviously correct patches, which I can just slurp in.

Linus Torvalds· Jul 31, 2005, 04:12 UTC · re: Junio C Hamano · lore

Re: [PATCH] add NO_CURL option to the Makefile

On Sat, 30 Jul 2005, Junio C Hamano wrote:

> 
> I love it I can just slow down and let others submit obviously
> correct patches, which I can just slurp in.

You're obviously doing well as a maintainer. Only stupid people try to do everything themselves.

Personally, I spend a _lot_ of time communicating, because even if it's a lot more work to explain (in detail) what I want done, and it doesn't work out all the time, and I sometimes have to do it myself _anyway_, if it works even just occasionally, it not only gets people involved, it makes them do it themselves next time around without prodding, and then you just sit back, sip a foofy tropical drink, and take the credit.

		Linus