threads / bug / 13704

Bug in git-log --date=short --pretty=format:"%ad"

Subject: Bug in git-log --date=short --pretty=format:"%ad"

## tl;dr

2 messages between May 28, 2008 and May 28, 2008.

replies: 1people: 2as markdown or json

Christophe GRENIER· May 28, 2008, 13:49 UTC · lore

Hi,

According to the git-log man page, we can configure how date are displayed:

--date={relative,local,default,iso,rfc}
   Only takes effect for dates shown in human-readable format,
   such as when using "--pretty".

But it doesn't work when a user supplied format is used:

git-log --date=short --pretty=format:"%ad" Wed May 28 13:28:35 2008 +0200 Wed May 28 13:26:14 2008 +0200 ...

instead of 2008-05-28 2008-05-28 ...

In pretty.c, when pretty_print_commit() calls format_commit_message(), dmode isn't passed as argument so format_commit_item() will never have the date format specified at the command line. This problem is present in git-1.5.5.3

Regards,

 	Christophe

-- 
    ,-~~-.___.     ._.
   / |  '     \    | |"""""""""|   Christophe GRENIER
  (  )         0   | |         | grenier@cgsecurity.org
   \_/-, ,----'    | |         |
      ====         !_!--v---v--"
      /  \-'~;      |""""""""|   TestDisk & PhotoRec
     /  __/~| ._-""||        |   Data Recovery
   =(  _____|_|____||________|   http://www.cgsecurity.org

Junio C Hamano· May 28, 2008, 15:11 UTC · re: Christophe GRENIER · lore

Re: Bug in git-log --date=short --pretty=format:"%ad"

Christophe GRENIER <grenier@cgsecurity.org> writes:

Show 8 quoted lines

> According to the git-log man page, we can configure how date are
> displayed:
>
> --date={relative,local,default,iso,rfc}
>   Only takes effect for dates shown in human-readable format,
>   such as when using "--pretty".
>
> But it doesn't work when a user supplied format is used:

Sorry, in theory, perhaps they could, but it doesn't and it never did. The output is working as designed and intended.

You probably could send a patch to add %aT and %cT that are defined as "author/committer date in the format specified with --date=<this> option"; but "%ad" and "%cd" are defined to emit "author/committer date always in the default format".