threads / patch / 13561

patchbuiltin-clone.c: Need to closedir() in copy_or_link_directory()

Subject: [PATCH] builtin-clone.c: Need to closedir() in copy_or_link_directory()

## tl;dr

One message between May 18, 2008 and May 18, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

drafnel@gmail.com· May 18, 2008, 04:00 UTC · lore
From: Brandon Casey <drafnel@gmail.com>
So not to leak file descriptors, close the directory after opening it.
Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 builtin-clone.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to builtin-clone.c +1 −0
diff --git a/builtin-clone.c b/builtin-clone.c
index 8713128..8936a51 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -215,6 +215,7 @@ static void copy_or_link_directory(char *src, char *dest)
 				die("failed to create link %s\n", dest);
 		}
 	}
+	closedir(dir);
 }
 
 static const struct ref *clone_local(const char *src_repo,
-- 
1.5.5.1.447.geb0a7

← back to recent threads