threads / patch / 13510

patchUpdating documentation to match Brandon Casey's proposed git-repack patch.

Subject: [PATCH] Updating documentation to match Brandon Casey's proposed git-repack patch.

## tl;dr

2 messages between May 14, 2008 and May 14, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Chris Frey· May 14, 2008, 07:25 UTC · lore

I haven't heard any negative commentary on this patch, and I see the repack patch is in next, so resending in case it was missed.

This patch clarifies the git-prune man page, documenting that it only prunes unpacked objects. git-repack is documented according to the new git-repack -A behaviour, which does not depend on git-pack-objects --keep-unreachable anymore.

Signed-off-by: Chris Frey <cdfrey@foursquare.net>
---
 Documentation/git-prune.txt  |    5 ++++-
 Documentation/git-repack.txt |   14 +++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)
Show changes to 2 files +17 −2

Documentation/git-prune.txt, Documentation/git-repack.txt

diff --git a/Documentation/git-prune.txt b/Documentation/git-prune.txt
index f92bb8c..3178bc4 100644
--- a/Documentation/git-prune.txt
+++ b/Documentation/git-prune.txt
@@ -18,12 +18,15 @@ git-prune. See the section "NOTES", below.
 
 This runs `git-fsck --unreachable` using all the refs
 available in `$GIT_DIR/refs`, optionally with additional set of
-objects specified on the command line, and prunes all
+objects specified on the command line, and prunes all unpacked
 objects unreachable from any of these head objects from the object database.
 In addition, it
 prunes the unpacked objects that are also found in packs by
 running `git prune-packed`.
 
+Note that unreachable, packed objects will remain.  If this is
+not desired, see linkgit:git-repack[1].
+
 OPTIONS
 -------
 
diff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt
index 3d95749..906d3c7 100644
--- a/Documentation/git-repack.txt
+++ b/Documentation/git-repack.txt
@@ -8,7 +8,7 @@ git-repack - Pack unpacked objects in a repository
 
 SYNOPSIS
 --------
-'git-repack' [-a] [-d] [-f] [-l] [-n] [-q] [--window=N] [--depth=N]
+'git-repack' [-a] [-A] [-d] [-f] [-l] [-n] [-q] [--window=N] [--depth=N]
 
 DESCRIPTION
 -----------
@@ -37,6 +37,18 @@ OPTIONS
 	leaves behind, but `git fsck --full` shows as
 	dangling.
 
+-A::
+	Same as `-a`, but any unreachable objects in a previous
+	pack become loose, unpacked objects, instead of being
+	left in the old pack.  Unreachable objects are never
+	intentionally added to a pack, even when repacking.
+	When used with '-d', this option
+	prevents unreachable objects from being immediately
+	deleted by way of being left in the old pack and then
+	removed.  Instead, the loose unreachable objects
+	will be pruned according to normal expiry rules
+	with the next linkgit:git-gc[1].
+
 -d::
 	After packing, if the newly created packs make some
 	existing packs redundant, remove the redundant packs.
-- 
1.5.4.4
Johannes Schindelin· May 14, 2008, 08:26 UTC · re: Chris Frey · lore

Re: [PATCH] Updating documentation to match Brandon Casey's proposed git-repack patch.

Hi,
On Wed, 14 May 2008, Chris Frey wrote:
> I haven't heard any negative commentary on this patch, and I see
> the repack patch is in next, so resending in case it was missed.

This part, together with the subject, is not really meant for application as-is, is it? Please follow the guidelines for SubmittingPatches, and write supporting arguments that are not meant to be part of the commit messages _after_ the "---".

Ciao, Dscho

← back to recent threads