threads / patch / 13284

patch, 2 partsrebase -i: Use : in expr command instead of match.

Subject: [PATCH 1/2] rebase -i: Use : in expr command instead of match.

## tl;dr

One message between Apr 27, 2008 and Apr 27, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Brian Gernhardt· Apr 27, 2008, 15:10 UTC · lore

`expr match $str $pattern` failed on OS X, and we already use `expr $str : $pattern` in several other commands.

Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
---
 git-rebase--interactive.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-rebase--interactive.sh +1 −1
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 303b754..2a01182 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -192,7 +192,7 @@ peek_next_command () {
 }
 
 mark_to_ref () {
-	if expr match "$1" "^:[0-9][0-9]*$" >/dev/null
+	if expr "$1" : "^:[0-9][0-9]*$" >/dev/null
 	then
 		echo "$mark_prefix$(printf %d ${1#:})"
 	else
-- 
1.5.5.1.174.g8f57349

← back to recent threads