# [BUG] git svn accepts to clone an empty SVN repo, but then fails to dcommit 4 messages from 2008-04-24 to 2008-05-05. Participants: Matthieu Moy, Eric Wong. Thread: https://gitlist.dev/t/13246 ## Matthieu Moy, 2008-04-24 18:06 Subject: [BUG] git svn accepts to clone an empty SVN repo, but then fails to dcommit Message-ID: URL: https://gitlist.dev/e/vpq3apbm8k3.fsf%40bauges.imag.fr ``` Hi, All is in the title ;-). The command git svn clone (URL of an empty SVN repo here) works, creates an empty git repository. I can perform the initial commit there, but then, "git svn dcommit" says : Use of uninitialized value in concatenation (.) or string at /home/moy/local/usr/bin/git-svn line 414. Committing to ... Unable to determine upstream SVN information from HEAD history I guess a correct management of the initial commit in git-svn would be hard to implement, but at least, the error message can be improved. First step is something like the patch below, and better would be for "git svn clone" to warn that it won't be able to do much with the cloned repo. diff --git a/git-svn.perl b/git-svn.perl index b864b54..9a70c1e 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -410,10 +410,12 @@ sub cmd_dcommit { $head ||= 'HEAD'; my @refs; my ($url, $rev, $uuid, $gs) = working_head_info($head, \@refs); - print "Committing to $url ...\n"; + if ($url) { + print "Committing to $url ...\n"; + } unless ($gs) { die "Unable to determine upstream SVN information from ", - "$head history\n"; + "$head history.\nPerhaps the repository is empty."; } my $last_rev; my ($linear_refs, $parents) = linearize_history($gs, \@refs); -- Matthieu ``` ## Eric Wong, 2008-04-29 07:15 Subject: Re: [BUG] git svn accepts to clone an empty SVN repo, but then fails to dcommit Message-ID: <20080429071552.GH24171@muzzle> URL: https://gitlist.dev/e/20080429071552.GH24171%40muzzle In-Reply-To: ``` Matthieu Moy wrote: > Hi, > > All is in the title ;-). > > The command > > git svn clone (URL of an empty SVN repo here) > > works, creates an empty git repository. I can perform the initial > commit there, but then, "git svn dcommit" says : > > Use of uninitialized value in concatenation (.) or string at /home/moy/local/usr/bin/git-svn line 414. > Committing to ... > Unable to determine upstream SVN information from HEAD history > > I guess a correct management of the initial commit in git-svn would be > hard to implement, but at least, the error message can be improved. > First step is something like the patch below, and better would be for > "git svn clone" to warn that it won't be able to do much with the > cloned repo. Thanks Matthieu, It shouldn't be *that* hard to implement being able to start an empty SVN repository from scratch, actually. Of course, there are about a billion other things people have been asking for in git-svn that I keep forgetting to implement. Acked-by: Eric Wong > diff --git a/git-svn.perl b/git-svn.perl > index b864b54..9a70c1e 100755 > --- a/git-svn.perl > +++ b/git-svn.perl > @@ -410,10 +410,12 @@ sub cmd_dcommit { > $head ||= 'HEAD'; > my @refs; > my ($url, $rev, $uuid, $gs) = working_head_info($head, \@refs); > - print "Committing to $url ...\n"; > + if ($url) { > + print "Committing to $url ...\n"; > + } > unless ($gs) { > die "Unable to determine upstream SVN information from ", > - "$head history\n"; > + "$head history.\nPerhaps the repository is empty."; > } > my $last_rev; > my ($linear_refs, $parents) = linearize_history($gs, \@refs); > -- Eric Wong ``` ## Matthieu Moy, 2008-05-05 08:18 Subject: [PATCH] Better error message for git svn dcommit on empty repository. Message-ID: <1209975508-9998-1-git-send-email-Matthieu.Moy@imag.fr> URL: https://gitlist.dev/e/1209975508-9998-1-git-send-email-Matthieu.Moy%40imag.fr In-Reply-To: <20080429071552.GH24171@muzzle> ``` Ideally, git-svn should be able to do the initial commit, but since it isn't, this patch makes it give an accurate error message. Acked-by: Eric Wong Signed-off-by: Matthieu Moy --- git-svn.perl | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index b864b54..9a70c1e 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -410,10 +410,12 @@ sub cmd_dcommit { $head ||= 'HEAD'; my @refs; my ($url, $rev, $uuid, $gs) = working_head_info($head, \@refs); - print "Committing to $url ...\n"; + if ($url) { + print "Committing to $url ...\n"; + } unless ($gs) { die "Unable to determine upstream SVN information from ", - "$head history\n"; + "$head history.\nPerhaps the repository is empty."; } my $last_rev; my ($linear_refs, $parents) = linearize_history($gs, \@refs); -- 1.5.5.1.72.gccbb6.dirty ``` ## Matthieu Moy, 2008-05-05 09:13 Subject: Re: [PATCH] Better error message for git svn dcommit on empty repository. Message-ID: URL: https://gitlist.dev/e/vpqve1txgdw.fsf%40bauges.imag.fr In-Reply-To: <1209975508-9998-1-git-send-email-Matthieu.Moy@imag.fr> ``` Matthieu Moy writes: > Ideally, git-svn should be able to do the initial commit, but since it > isn't, this patch makes it give an accurate error message. Oops, I just noticed that the patch had already been applied. Sorry for the noise. -- Matthieu ```