threads / patch / 13176
Subject: Re: [PATCH] Docs gitk: Explicitly mention -d, --date-order option
Git Mailing List, Git Maintainer:
Regarding the documentation patch "[PATCH] Docs gitk: Explicitly mention -d, --date-order option" [1] (2008-04-12), it has not been accepted. Is there problem with this patch?
References: [1] http://marc.info/?l=git&m=120799377618677&w=2
Best regards, Clifford Caoile
Junio C Hamano"Clifford Caoile" <piyo@users.sourceforge.net> writes:
> Git Mailing List, Git Maintainer:
Heh, my name is not "Git Maintainer" ;-)
> Regarding the documentation patch "[PATCH] Docs gitk: Explicitly > mention -d, --date-order option" [1] (2008-04-12), it has not been > accepted. Is there problem with this patch? > > References: > [1] http://marc.info/?l=git&m=120799377618677&w=2
There isn't anything _wrong_ with the patch per se, but the current documentation refers you to rev-list page and limits itself to the most often used options.
I was waiting to see that many people jumping up and down saying that the omission of --date-order from the "most often used" set was a grave bug before applying it. It hasn't happened.
On Fri, 2008-04-18 at 23:58 -0700, Junio C Hamano wrote:
> I was waiting to see that many people jumping up and down saying that the > omission of --date-order from the "most often used" set was a grave bug > before applying it. It hasn't happened.
I'm glad we had this thread because I missed this option before ...
best regards, Ray
Junio C Hamano:
On Sat, Apr 19, 2008 at 3:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
> "Clifford Caoile" <piyo@users.sourceforge.net> writes: > > Git Mailing List, Git Maintainer: > Heh, my name is not "Git Maintainer" ;-)
Sorry about that. Just adding another layer of indirection. >:-]
> > Regarding the documentation patch "[PATCH] Docs gitk: Explicitly > > mention -d, --date-order option" [1] (2008-04-12), it has not been > > accepted. Is there problem with this patch? > > > > References: > > [1] http://marc.info/?l=git&m=120799377618677&w=2 > > There isn't anything _wrong_ with the patch per se, but the current > documentation refers you to rev-list page and limits itself to the most > often used options. > > I was waiting to see that many people jumping up and down saying that the > omission of --date-order from the "most often used" set was a grave bug > before applying it. It hasn't happened.
The whole motivation for adding this documentation is to show that gitk has the same sorting function as git-browser. I only learned of this capability through the irc channel.
As a git newbie, it wasn't obvious to me that "--date-order" was an available option. It has become my usual parameter when launching gitk on branch/merge heavy repos. Besides, and more importantly, the equivalent "-d" is a gitk only parameter that should probably be documented as well. I had to read the gitk tcl source for that one. ;-)
Best regards, Clifford Caoile
Hello Junio,
you wrote on 2008-04-18:
> "Clifford Caoile" <piyo@users.sourceforge.net> writes:
[...]
>> Regarding the documentation patch "[PATCH] Docs gitk: Explicitly >> mention -d, --date-order option" [1] (2008-04-12), it has not been >> accepted. Is there problem with this patch? >> >> References: >> [1] http://marc.info/?l=git&m=120799377618677&w=2 > > There isn't anything _wrong_ with the patch per se, but the current > documentation refers you to rev-list page and limits itself to the most > often used options. > > I was waiting to see that many people jumping up and down saying that the > omission of --date-order from the "most often used" set was a grave bug > before applying it. It hasn't happened.
This thread has helped me finding "-d" (which is gitk-specific). So here's my vote for the patch, FWIW.
Robert