threads / bug / 13084

[BUG] --pretty=format does not work ok with rev-list

Subject: [BUG] --pretty=format does not work ok with rev-list

## tl;dr

3 messages between Apr 12, 2008 and Apr 25, 2008.

replies: 2people: 3as markdown or json

k0001· Apr 12, 2008, 20:40 UTC · lore

Hello list, my name is Renzo Carbonara and I'm new here in the git neighborhood.

Now back to business, when using --pretty=format:some_format with git rev-list, an additional non-requested line is printed before every commit ("commit <sha1_id>"). Example:

git rev-list output (BAD):

k@k0001 ~/linux-2.6 $ git rev-list -2 --pretty=format:"%H: %cn" master commit f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed: Linus Torvalds commit 44cad261025c04327fd7e847a7088fd3031b0c3e 44cad261025c04327fd7e847a7088fd3031b0c3e: Linus Torvalds

git log output (GOOD):

k@k0001 ~/linux-2.6 $ git log -2 --pretty=format:"%H: %cn" master f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed: Linus Torvalds 44cad261025c04327fd7e847a7088fd3031b0c3e: Linus Torvalds

this was tested with versions:
 - 1.5.3.7
 - 4cdda2b895dfb6ba084e3952cbf4274a6a2e0338
Cheers,
Renzo Carbonara
Jörg Sommer· Apr 25, 2008, 09:14 UTC · re: k0001 · lore

Re: [BUG] --pretty=format does not work ok with rev-list

Hi,
k0001 <gnuk0001@gmail.com> wrote:
Show 11 quoted lines
> Now back to business, when using --pretty=format:some_format with git
> rev-list, an additional non-requested line is printed before every
> commit ("commit <sha1_id>"). Example:
>
> git rev-list output (BAD):
>
> k@k0001 ~/linux-2.6 $ git rev-list -2 --pretty=format:"%H: %cn" master
> commit f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed
> f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed: Linus Torvalds
> commit 44cad261025c04327fd7e847a7088fd3031b0c3e
> 44cad261025c04327fd7e847a7088fd3031b0c3e: Linus Torvalds

Is this a bug? I've the same “problem” in my rebase with merge patch series and added a “|grep -v ^commit”. But if this is a bug, I can remove it.

Schöne Grüße, Jörg.
-- 
Viele Leute glauben, dass sie denken, wenn sie lediglich
ihre Vorurteile neu ordnen.
Junio C Hamano· Apr 25, 2008, 18:24 UTC · re: Jörg Sommer · lore

Re: [BUG] --pretty=format does not work ok with rev-list

Jörg Sommer <joerg@alea.gnuu.de> writes:
Show 9 quoted lines
>> k@k0001 ~/linux-2.6 $ git rev-list -2 --pretty=format:"%H: %cn" master
>> commit f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed
>> f4be31ec9690cfe6e94fcbed6ae60a6a38b3c3ed: Linus Torvalds
>> commit 44cad261025c04327fd7e847a7088fd3031b0c3e
>> 44cad261025c04327fd7e847a7088fd3031b0c3e: Linus Torvalds
>
> Is this a bug? I've the same “problem” in my rebase with merge patch
> series and added a “|grep -v ^commit”. But if this is a bug, I can remove
> it.

I personally do not think the above is a particularly desirable output, but that's how rev-list worked for a long time and existing scripts probably expect it that way.

rev-list is for script consumption, and giving --pretty=format that has %H in it would be asking for redundant information.

← back to recent threads