[REGRESSION] git-gui

> Hi, all!
>
>     After updating to git version 1.5.5.rc3 I always get the error below
>  when starting "git gui".
>     Linux distributions used are opensuse 10 and opensuse Factory.
>
>  # git gui
>  Error in startup script: bad event type or keysym "["
>     while executing
>  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
>     file "/usr/bin/git-gui" linux 2718)
>
>     I think it's related to git-gui 0.10 recently added into the tree.

> On Thu, Apr 3, 2008 at 2:43 PM, André Goddard Rosa <andre_rosa@lge.com> wrote:
> > Hi, all!
> >
> >     After updating to git version 1.5.5.rc3 I always get the error below
> >  when starting "git gui".
> >     Linux distributions used are opensuse 10 and opensuse Factory.
> >
> >  # git gui
> >  Error in startup script: bad event type or keysym "["
> >     while executing
> >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
> >     file "/usr/bin/git-gui" linux 2718)
> >
> >     I think it's related to git-gui 0.10 recently added into the tree.
> 
> Doh, I broke git :(
> 
> The problem is in c91ee2bd61 (Add shortcut keys for Show More/Less Context).
> Works fine on my OS X 10.5 installation with tcl 8.4.7 - can anyone
> suggest an alternative way of binding the left/right brackets?  I'm
> not familiar with Tcl, and didn't manage to find a list of key names.

>
> On Thursday 03 April 2008, Jonathan del Strother wrote:
>  > On Thu, Apr 3, 2008 at 2:43 PM, André Goddard Rosa <andre_rosa@lge.com> wrote:
>  > > Hi, all!
>  > >
>  > >     After updating to git version 1.5.5.rc3 I always get the error below
>  > >  when starting "git gui".
>  > >     Linux distributions used are opensuse 10 and opensuse Factory.
>  > >
>  > >  # git gui
>  > >  Error in startup script: bad event type or keysym "["
>  > >     while executing
>  > >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
>  > >     file "/usr/bin/git-gui" linux 2718)
>  > >
>  > >     I think it's related to git-gui 0.10 recently added into the tree.
>  >
>  > Doh, I broke git :(
>  >
>  > The problem is in c91ee2bd61 (Add shortcut keys for Show More/Less Context).
>  > Works fine on my OS X 10.5 installation with tcl 8.4.7 - can anyone
>  > suggest an alternative way of binding the left/right brackets?  I'm
>  > not familiar with Tcl, and didn't manage to find a list of key names.
>
>  These changes should help (haven't tried):
>         \[ -> bracketleft
>         \] -> bracketright
>  but some European keyboards do not have easy access to brackets, so
>  other keys would be preferable (comma and period, for example, or 1 and 2).
>
>  See
>         man keysyms
>  for a list of key names.
>

> On Thu, Apr 3, 2008 at 10:04 PM, Michele Ballabio
> <barra_cuda@katamail.com> wrote:
> > On Thursday 03 April 2008, Jonathan del Strother wrote:
> >  > On Thu, Apr 3, 2008 at 2:43 PM, André Goddard Rosa <andre_rosa@lge.com> wrote:
> >  > >
> >  > >  # git gui
> >  > >  Error in startup script: bad event type or keysym "["
> >  > >     while executing
> >  > >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
> >  >
> >  > Doh, I broke git :(

> >  These changes should help (haven't tried):
> >         \[ -> bracketleft
> >         \] -> bracketright
> >  but some European keyboards do not have easy access to brackets, so
> >  other keys would be preferable (comma and period, for example, or 1 and 2).
> 
> Anyone else got any opinions on an appropriate shortcut?  How about
> '=' and '-' (+ and - without the shift), or are those not necessarily
> together either?  (Are there really layouts where '[' and ']' aren't
> next to each other?)

> Jonathan del Strother <maillist@steelskies.com> wrote:
> > >  > >  # git gui
> > >  > >  Error in startup script: bad event type or keysym "["
> > >  > >     while executing
> > >  > >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
> 
> > >  These changes should help (haven't tried):
> > >         \[ -> bracketleft
> > >         \] -> bracketright
> > >  but some European keyboards do not have easy access to brackets, so
> > >  other keys would be preferable (comma and period, for example, or 1 and 2).
> 
> I wrote up a patch today based on Michele's suggested change.

> Hmm, maybe I should offer the patch.  :-)
> 
> --8>--
> Subject: [PATCH] git-gui: Switch keybindings for [ and ] to bracketleft and bracketright
> 
> Thanks to Michele Ballabio for the quick fix.
> This resolves the error introduced by c91ee2bd61.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

> Hmm, maybe I should offer the patch.  :-)
> 
> --8>--
> Subject: [PATCH] git-gui: Switch keybindings for [ and ] to 
> bracketleft and bracketright
> 
> Thanks to Michele Ballabio for the quick fix.
> This resolves the error introduced by c91ee2bd61.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

> > Anyone else got any opinions on an appropriate shortcut?  How about
> > '=' and '-' (+ and - without the shift), or are those not necessarily
> > together either?  (Are there really layouts where '[' and ']' aren't
> > next to each other?)
> 
> I don't know, [ and ] seem reasonable to me.  Git is mostly a source
> code control system.  A lot of languages use [ and ] as part of
> their syntax.  If you are typing on a keyboard that is difficult to
> access these keys on, you are probably already used to contorting
> your fingers.  :-|

> I wrote up a patch today based on Michele's suggested change.
> It works everywhere I can test, but I don't have an 8.4.0
> installation like the original poster.
> 
> Unless someone posts a patch to change the keys away from [ and ]
> I say leave them as-is.  But I'm willing to entertain a change if
> someone who cares writes a patch for it.

>  	.mbar.commit add command -label [mc "Show Less Context"] \
>  		-command show_less_context \
> -		-accelerator $M1T-\[
> +		-accelerator $M1T-\-
>  
>  	.mbar.commit add command -label [mc "Show More Context"] \
>  		-command show_more_context \
> -		-accelerator $M1T-\]
> +		-accelerator "$M1T-+ $M1T-="

> @@ -2715,8 +2715,11 @@ bind $ui_comm <$M1B-Key-v> {tk_textPaste %W; %W see insert; break}
>  bind $ui_comm <$M1B-Key-V> {tk_textPaste %W; %W see insert; break}
>  bind $ui_comm <$M1B-Key-a> {%W tag add sel 0.0 end;break}
>  bind $ui_comm <$M1B-Key-A> {%W tag add sel 0.0 end;break}
> -bind $ui_comm <$M1B-Key-bracketleft> {show_less_context;break}
> -bind $ui_comm <$M1B-Key-bracketright> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-minus> {show_less_context;break}
> +bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}
> +bind $ui_comm <$M1B-Key-equal> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-plus> {show_more_context;break}
> +bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}
>  
>  bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}
>  bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}
> @@ -2760,8 +2763,11 @@ bind .   <$M1B-Key-t> do_add_selection
>  bind .   <$M1B-Key-T> do_add_selection
>  bind .   <$M1B-Key-i> do_add_all
>  bind .   <$M1B-Key-I> do_add_all
> -bind .   <$M1B-Key-bracketleft> {show_less_context;break}
> -bind .   <$M1B-Key-bracketright> {show_more_context;break}
> +bind .   <$M1B-Key-minus> {show_less_context;break}
> +bind .   <$M1B-Key-KP_Subtract> {show_less_context;break}
> +bind .   <$M1B-Key-equal> {show_more_context;break}
> +bind .   <$M1B-Key-plus> {show_more_context;break}
> +bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>  bind .   <$M1B-Key-Return> do_commit
>  foreach i [list $ui_index $ui_workdir] {
>  	bind $i <Button-1>       "toggle_or_diff         $i %x %y; break"
> -- 
> 1.5.4.5
> 

> "Jonathan del Strother" <maillist@steelskies.com> writes:
> 
> > Anyone else got any opinions on an appropriate shortcut?  How about
> > '=' and '-' (+ and - without the shift), or are those not
> > necessarily together either?  (Are there really layouts where '['
> > and ']' aren't next to each other?)
> 
> A Swedish keyboard has [] on alt-gr (Modeshift) 8 and 9.  Plus and
> minus are unshifted and = is on shift-0.
> 
> So with a Swedish layout, it is annoying when zoom in is on = rather
> than +, just because someone assumed that it would be harder to press
> the more logical plus key.

> David Kågedal kirjoitti (7.4.2008 klo 9.38):
> > "Jonathan del Strother" <maillist@steelskies.com> writes:
> > 
> > > Anyone else got any opinions on an appropriate shortcut?  How about
> > > '=' and '-' (+ and - without the shift), or are those not
> > > necessarily together either?  (Are there really layouts where '['
> > > and ']' aren't next to each other?)
> > 
> > A Swedish keyboard has [] on alt-gr (Modeshift) 8 and 9.  Plus and
> > minus are unshifted and = is on shift-0.
> > 
> > So with a Swedish layout, it is annoying when zoom in is on = rather
> > than +, just because someone assumed that it would be harder to press
> > the more logical plus key.
> 
> The above also applies to Finnish and Norwegian keyboards, probably to
> many more. The key pair '=' and '-' would be a poor UI decision. In
> principle one should never assume that a key is in certain place in the
> keyboard; it's much better idea to be logical with _characters_. So if
> a key pair much be defined for different aspects of the same
> functionality, let's choose logical pairs from common characters: +- []
> {} () <> zZ aA bB ... (To me all these are OK.)