threads / discuss / 12946

Sending patches via gmail

Subject: Sending patches via gmail

## tl;dr

4 messages between Apr 1, 2008 and Apr 1, 2008.

replies: 3people: 3as markdown or json

Jonathan del Strother· Apr 1, 2008, 09:49 UTC · lore

I can't seem to send patches via gmail without it adding spurious line
breaks -  eg http://article.gmane.org/gmane.comp.version-control.git/78407.
 I thought this was supposed to be possible...  All I'm doing is
copying the contents of my patch, then in Gmail, clicking Compose
Mail, make sure it's in Plain Text rather than Rich Formatting mode,
paste my patch, and moving the mail header lines out of the message
body.

What am I missing? Jonathan del Strother

David Aguilar· Apr 1, 2008, 10:09 UTC · re: Jonathan del Strother · lore

Re: Sending patches via gmail

On 4/1/08, Jonathan del Strother <maillist@steelskies.com> wrote:

Show 10 quoted lines

> I can't seem to send patches via gmail without it adding spurious line
>  breaks -  eg http://article.gmane.org/gmane.comp.version-control.git/78407.
>   I thought this was supposed to be possible...  All I'm doing is
>  copying the contents of my patch, then in Gmail, clicking Compose
>  Mail, make sure it's in Plain Text rather than Rich Formatting mode,
>  paste my patch, and moving the mail header lines out of the message
>  body.
>
>  What am I missing?
>  Jonathan del Strother

Try git send-email w/ msmtp: http://git.or.cz/gitwiki/GitTips#head-a015948617d9becbdc9836776f96ad244ba87cb8

-- 
    David

Jonathan del Strother· Apr 1, 2008, 10:51 UTC · re: David Aguilar · lore

Re: Sending patches via gmail

On Tue, Apr 1, 2008 at 11:09 AM, David Aguilar <davvid@gmail.com> wrote:

Show 19 quoted lines

> On 4/1/08, Jonathan del Strother <maillist@steelskies.com> wrote:
>
>
> > I can't seem to send patches via gmail without it adding spurious line
>  >  breaks -  eg http://article.gmane.org/gmane.comp.version-control.git/78407.
>  >   I thought this was supposed to be possible...  All I'm doing is
>  >  copying the contents of my patch, then in Gmail, clicking Compose
>  >  Mail, make sure it's in Plain Text rather than Rich Formatting mode,
>  >  paste my patch, and moving the mail header lines out of the message
>  >  body.
>  >
>  >  What am I missing?
>  >  Jonathan del Strother
>
>
>
> Try git send-email w/ msmtp:
>  http://git.or.cz/gitwiki/GitTips#head-a015948617d9becbdc9836776f96ad244ba87cb8
>

...which seems to work ok, except for the fact that the From line in my patch (the output of git format-patch) then appears at the top of my message body in the resulting email (from git send-email). Deleting the From line from the patch seems to make everything work as expected. Any ideas what's going on there?

Jeff King· Apr 1, 2008, 11:03 UTC · re: Jonathan del Strother · lore

Re: Sending patches via gmail

On Tue, Apr 01, 2008 at 11:51:38AM +0100, Jonathan del Strother wrote:

Show 5 quoted lines

> ...which seems to work ok, except for the fact that the From line in
> my patch (the output of git format-patch) then appears at the top of
> my message body in the resulting email (from git send-email).
> Deleting the From line from the patch seems to make everything work as
> expected.  Any ideas what's going on there?

send-email will create a "from" line in the body of the message if the "sender" (using --from, or answering "Who should the emails appear to be from") doesn't match the patch's author (the "From:" line in the generated patch, which comes from the author field of the commit). The line is interpeted by git-am to properly credit the original author.

It looks like you are committing as jon.delStrother@bestbefore.tv, but sending the emails as maillist@steelskies.com.

-Peff