# What git config --replace-all ONE_ARG should do?

2 messages from 2008-03-26 to 2008-03-26. Participants: Carlos Rica, Junio C Hamano.
Thread: https://gitlist.dev/t/12873

## Carlos Rica, 2008-03-26 13:50

Subject: What git config --replace-all ONE_ARG should do?
Message-ID: <1b46aba20803260650o5e425250sb532a3b3197a1ecf@mail.gmail.com>
URL: https://gitlist.dev/e/1b46aba20803260650o5e425250sb532a3b3197a1ecf%40mail.gmail.com

```
The command 'git config --replace-all ONE_ARG' currently
tries to do the same as the command 'git config NAME VALUE',
using --replace-all as the NAME and ONE_ARG as VALUE,
printing "key does not contain a section: --replace-all".

What this command should do? I'm almost finnishing
buitin-config.c to use parse-options and I need to know
if that command should do something or just showing
the help and exit in such case.

I think that --replace-all should always receive at least
two arguments. The documentation currently says:
git-config ... --replace-all name [value [value_regex]]
and current tests are only cheking two arguments.

Since I cannot imagine a consistent action to do
when only the name is given and nobody complains
I will do this to print the help message and exit.

Cheers

--
Carlos

```

## Junio C Hamano, 2008-03-26 21:24

Subject: Re: What git config --replace-all ONE_ARG should do?
Message-ID: <7v7ifpch6q.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v7ifpch6q.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <1b46aba20803260650o5e425250sb532a3b3197a1ecf@mail.gmail.com>

```
"Carlos Rica" <jasampler@gmail.com> writes:

> The command 'git config --replace-all ONE_ARG' currently
> tries to do the same as the command 'git config NAME VALUE',
> using --replace-all as the NAME and ONE_ARG as VALUE,
> printing "key does not contain a section: --replace-all".

That sounds silly, and I think it is an improvement to error out in such a
case.

```