threads / patch / 12830

patch, 4 partsAdd private modifier for private variables in the FindToolbar.

Subject: [EGIT PATCH 1/4] Add private modifier for private variables in the FindToolbar.

## tl;dr

One message between Mar 24, 2008 and Mar 24, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Roger C. Soares· Mar 24, 2008, 02:57 UTC · lore
I overlooked this when doing the find toolbar. Fixing now.
Signed-off-by: Roger C. Soares <rogersoares@intelinet.com.br>
---
Hi Robin,

Here goes some more patches for your review. Currently they are on top of the last patches I sent you.

Patch 4/4 is the one that shows only the commits in the current branch. I don't see me going through Shawn's new machinery soon, so I'm just sending what I have today as a starting point for the feature.

[]s, Roger.

 .../src/org/spearce/egit/ui/FindToolbar.java       |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
Show changes to org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java +9 −9
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
index 5527453..3d2472c 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
@@ -65,27 +65,27 @@ public class FindToolbar extends Composite {
 	 */
 	public final FindResults findResults = new FindResults();
 
-	Preferences prefs = Activator.getDefault().getPluginPreferences();
+	private Preferences prefs = Activator.getDefault().getPluginPreferences();
 
-	List<Listener> eventList = new ArrayList<Listener>();
+	private List<Listener> eventList = new ArrayList<Listener>();
 
 	private Image nextIcon;
 
 	private Image previousIcon;
 
-	Table historyTable;
+	private Table historyTable;
 
-	List<IFileRevision> fileRevisions;
+	private List<IFileRevision> fileRevisions;
 
-	Text patternField;
+	private Text patternField;
 
-	Button nextButton;
+	private Button nextButton;
 
-	Button previousButton;
+	private Button previousButton;
 
-	Label currentPositionLabel;
+	private Label currentPositionLabel;
 
-	ProgressBar progressBar;
+	private ProgressBar progressBar;
 
 	private String lastErrorPattern;
 
-- 
1.5.4.1

← back to recent threads