threads / patch / 12806

patchgit add --interactive: Autoselect single patch file

Subject: [PATCH] git add --interactive: Autoselect single patch file

## tl;dr

4 messages between Mar 22, 2008 and Mar 22, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Jörg Sommer· Mar 22, 2008, 01:22 UTC · lore

If there's only one file to patch, select it automaticly and don't bother the user. In the case he didn't want do patching, he can say 'd' at the patch prompt.

Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
---
 git-add--interactive.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-add--interactive.perl +1 −1
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index a0a81f1..77ad6fb 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -778,7 +778,7 @@ sub patch_update_cmd {
 		print STDERR "No changes.\n";
 		return 0;
 	}
-	if ($patch_mode) {
+	if ($patch_mode or @mods == 1) {
 		@them = @mods;
 	}
 	else {

-- 
1.5.4.4
Johannes Schindelin· Mar 22, 2008, 14:51 UTC · re: Jörg Sommer · lore

Re: [PATCH] git add --interactive: Autoselect single patch file

Hi,
On Sat, 22 Mar 2008, Jörg Sommer wrote:
> If there's only one file to patch, select it automaticly and don't 
> bother the user. In the case he didn't want do patching, he can say 'd' 
> at the patch prompt.
It also triggers when you specified a single path:
	$ git add -i that-file.c
I like it.

However, if I already specify (a) file(s), could add -i not go to the [p]atch option right away?

Ciao, Dscho

Wincent Colaiuta· Mar 22, 2008, 15:41 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git add --interactive: Autoselect single patch file

El 22/3/2008, a las 15:51, Johannes Schindelin escribió:
Show 17 quoted lines
> Hi,
>
> On Sat, 22 Mar 2008, Jörg Sommer wrote:
>
>> If there's only one file to patch, select it automaticly and don't
>> bother the user. In the case he didn't want do patching, he can say  
>> 'd'
>> at the patch prompt.
>
> It also triggers when you specified a single path:
>
> 	$ git add -i that-file.c
>
> I like it.
>
> However, if I already specify (a) file(s), could add -i not go to the
> [p]atch option right away?

That's what I originally wanted and I sent a couple of patches in to that effect some months back. But it was argued that it is useful for passed-in filepatterns to limit the scope of other operations in "git add -i", not just the [p] subcommand, and that in turn lead to the "-- patch" option being implemented. I can try to dig up the message-ids in question if you are interested.

Still, I use the [p] subcommand so often (and almost never use any of the other subcommands offered by "git add -i") that I have "git patch" set up as an alias for "git add --patch".

Cheers, Wincent

Johannes Schindelin· Mar 22, 2008, 16:00 UTC · re: Wincent Colaiuta · lore

Re: [PATCH] git add --interactive: Autoselect single patch file

Hi,
On Sat, 22 Mar 2008, Wincent Colaiuta wrote:
Show 15 quoted lines
> El 22/3/2008, a las 15:51, Johannes Schindelin escribió:
> 
> >However, if I already specify (a) file(s), could add -i not go to the 
> >[p]atch option right away?
> 
> That's what I originally wanted and I sent a couple of patches in to 
> that effect some months back. But it was argued that it is useful for 
> passed-in filepatterns to limit the scope of other operations in "git 
> add -i", not just the [p] subcommand, and that in turn lead to the 
> "--patch" option being implemented. I can try to dig up the message-ids 
> in question if you are interested.
> 
> Still, I use the [p] subcommand so often (and almost never use any of 
> the other subcommands offered by "git add -i") that I have "git patch" 
> set up as an alias for "git add --patch".
Ah, I missed the --patch option.

Thanks, Dscho

← back to recent threads