# [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out 3 messages from 2008-03-13 to 2008-03-14. Participants: Christian Couder, Junio C Hamano, Xavier Maillard. Thread: https://gitlist.dev/t/12664 ## Christian Couder, 2008-03-13 06:10 Subject: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Message-ID: <20080313071040.bbf5528b.chriscool@tuxfamily.org> URL: https://gitlist.dev/e/20080313071040.bbf5528b.chriscool%40tuxfamily.org ``` Signed-off-by: Christian Couder --- help.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This was suggested by Xavier Maillard. diff --git a/help.c b/help.c index 5da8c9c..ecaca77 100644 --- a/help.c +++ b/help.c @@ -139,7 +139,7 @@ static int add_man_viewer(const char *value) else if (!strcasecmp(value, "konqueror")) do_add_man_viewer(exec_man_konqueror); else - return error("'%s': unsupported man viewer.", value); + warning("'%s': unsupported man viewer.", value); return 0; } -- 1.5.4.3.395.g492b.dirty ``` ## Junio C Hamano, 2008-03-13 06:22 Subject: Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Message-ID: <7vzlt3ywha.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vzlt3ywha.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080313071040.bbf5528b.chriscool@tuxfamily.org> ``` Christian Couder writes: > Signed-off-by: Christian Couder > --- > help.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > This was suggested by Xavier Maillard. > > diff --git a/help.c b/help.c > index 5da8c9c..ecaca77 100644 > --- a/help.c > +++ b/help.c > @@ -139,7 +139,7 @@ static int add_man_viewer(const char *value) > else if (!strcasecmp(value, "konqueror")) > do_add_man_viewer(exec_man_konqueror); > else > - return error("'%s': unsupported man viewer.", value); > + warning("'%s': unsupported man viewer.", value); > > return 0; > } While I'd agree this is a good change, the author should justify it in the commit log message. I ask list regulars like you to set a good example for others. When a document viewer that is unknown to the current version of git is specified in the .git/config file, instead of erroring out the process completely, just issue a warning. It might be that the user usually is using a newer git that supports it (and the configuration is written for that version) but is temporarily using an older git that does not know the viewer. ``` ## Xavier Maillard, 2008-03-14 01:00 Subject: Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Message-ID: <200803140100.m2E104Qi004663@localhost.localdomain> URL: https://gitlist.dev/e/200803140100.m2E104Qi004663%40localhost.localdomain In-Reply-To: <20080313071040.bbf5528b.chriscool@tuxfamily.org> ``` Signed-off-by: Christian Couder It's perfect. Thank you Christian. Tested-by: Xavier Maillard Xavier -- http://www.gnu.org http://www.april.org http://www.lolica.org ```