threads / patch / 12521

patchbash: fix long option with argument double completion

Subject: [PATCH] bash: fix long option with argument double completion

## tl;dr

One message between Mar 5, 2008 and Mar 5, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

SZEDER Gábor· Mar 5, 2008, 19:07 UTC · lore

Pressing TAB right after 'git command --long-option=' results in 'git command --long-option=--long-option=' when the long option requires an argument, but we don't provide completion for its arguments (e.g. commit --author=, apply --exclude=). This patch detects these long options and provides empty completion array for them.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash |   22 +++++++++++++++-------
 1 files changed, 15 insertions(+), 7 deletions(-)
Show changes to contrib/completion/git-completion.bash +15 −7
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d890f16..18b4001 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -113,13 +113,21 @@ __gitcomp ()
 	if [ $# -gt 2 ]; then
 		cur="$3"
 	fi
-	for c in $1; do
-		case "$c$4" in
-		--*=*) all="$all$c$4$s" ;;
-		*.)    all="$all$c$4$s" ;;
-		*)     all="$all$c$4 $s" ;;
-		esac
-	done
+	case "$cur" in
+	--*=)
+		COMPREPLY=()
+		return
+		;;
+	*)
+		for c in $1; do
+			case "$c$4" in
+			--*=*) all="$all$c$4$s" ;;
+			*.)    all="$all$c$4$s" ;;
+			*)     all="$all$c$4 $s" ;;
+			esac
+		done
+		;;
+	esac
 	IFS=$s
 	COMPREPLY=($(compgen -P "$2" -W "$all" -- "$cur"))
 	return
-- 
1.5.4.3

← back to recent threads