# [PATCH 1/3] Don't allow git-describe failures to go unnoticed in t6120

1 messages from 2008-03-04 to 2008-03-04. Participants: Shawn O. Pearce.
Thread: https://gitlist.dev/t/12472

## Shawn O. Pearce, 2008-03-04 01:09

Subject: [PATCH 1/3] Don't allow git-describe failures to go unnoticed in t6120
Message-ID: <20080304010931.GA15791@spearce.org>
URL: https://gitlist.dev/e/20080304010931.GA15791%40spearce.org

```
If git-describe fails we never execute the test_expect_success,
so we never actually test for failure.  This is horribly wrong.
We need to always run the test case, but the test case is only
supposed to succeed if the prior git-describe returned 0.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 t/t6120-describe.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh
index a7557bd..ba9ea60 100755
--- a/t/t6120-describe.sh
+++ b/t/t6120-describe.sh
@@ -15,8 +15,10 @@ test_description='test describe
 check_describe () {
 	expect="$1"
 	shift
-	R=$(git describe "$@") &&
+	R=$(git describe "$@")
+	S=$?
 	test_expect_success "describe $*" '
+	test $S = 0 &&
 	case "$R" in
 	$expect)	echo happy ;;
 	*)	echo "Oops - $R is not $expect";
-- 
1.5.4.3.529.gb25fb


```