# [PATCH] receive-pack: Initialize PATH to include exec-dir. 3 messages from 2008-03-03 to 2008-03-03. Participants: Björn Steinbrink, Junio C Hamano, Bernt Hansen. Thread: https://gitlist.dev/t/12449 ## Björn Steinbrink, 2008-03-03 04:08 Subject: [PATCH] receive-pack: Initialize PATH to include exec-dir. Message-ID: <20080303040843.GA27185@atjola.homenet> URL: https://gitlist.dev/e/20080303040843.GA27185%40atjola.homenet ``` 511707d (use only the $PATH for exec'ing git commands) made it a requirement to call setup_path() to include the git exec-dir in PATH before spawning any other git commands. git-receive-pack was not yet adapted to do this and therefore fails to spawn git-unpack-objects if that is not in the standard PATH. Signed-off-by: Björn Steinbrink --- receive-pack.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/receive-pack.c b/receive-pack.c index a971433..f83ae87 100644 --- a/receive-pack.c +++ b/receive-pack.c @@ -471,6 +471,8 @@ int main(int argc, char **argv) if (!dir) usage(receive_pack_usage); + setup_path(NULL); + if (!enter_repo(dir, 0)) die("'%s': unable to chdir or not a git archive", dir); -- 1.5.4.3.1.g3b5b4 ``` ## Bernt Hansen, 2008-03-03 04:21 Subject: Re: [PATCH] receive-pack: Initialize PATH to include exec-dir. Message-ID: <87ve44cu9m.fsf@gollum.intra.norang.ca> URL: https://gitlist.dev/e/87ve44cu9m.fsf%40gollum.intra.norang.ca In-Reply-To: <20080303040843.GA27185@atjola.homenet> ``` Björn Steinbrink writes: > 511707d (use only the $PATH for exec'ing git commands) made it a > requirement to call setup_path() to include the git exec-dir in PATH > before spawning any other git commands. git-receive-pack was not yet > adapted to do this and therefore fails to spawn git-unpack-objects if that > is not in the standard PATH. > > Signed-off-by: Björn Steinbrink > --- > receive-pack.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/receive-pack.c b/receive-pack.c > index a971433..f83ae87 100644 > --- a/receive-pack.c > +++ b/receive-pack.c > @@ -471,6 +471,8 @@ int main(int argc, char **argv) > if (!dir) > usage(receive_pack_usage); > > + setup_path(NULL); > + > if (!enter_repo(dir, 0)) > die("'%s': unable to chdir or not a git archive", dir); > > -- > 1.5.4.3.1.g3b5b4 > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Tested by: Bernt Hansen ``` ## Junio C Hamano, 2008-03-03 04:58 Subject: Re: [PATCH] receive-pack: Initialize PATH to include exec-dir. Message-ID: <7vtzjojtet.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vtzjojtet.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080303040843.GA27185@atjola.homenet> ``` I think this is a sensible companion patch to the earlier 04b3305 (upload-pack: Initialize the exec-path.). We should have done this back then. Thanks. ```