Shawn O. PearceWe can free this ref_map as soon as the fetch is complete. It is not used for the automatic tag following, nor is it used to disconnect the transport. This avoids some confusion about why we are holding onto these refs while following tags.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- builtin-fetch.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
Show changes to builtin-fetch.c +2 −4
diff --git a/builtin-fetch.c b/builtin-fetch.c index f8b9542..1348a0e 100644 --- a/builtin-fetch.c +++ b/builtin-fetch.c @@ -509,7 +509,7 @@ static struct ref *find_non_local_tags(struct transport *transport) static int do_fetch(struct transport *transport, struct refspec *refs, int ref_count) { - struct ref *ref_map, *fetch_map; + struct ref *ref_map; struct ref *rm; int autotags = (transport->remote->fetch_tags == 1); if (transport->remote->fetch_tags == 2 && tags != TAGS_UNSET) @@ -540,8 +540,7 @@ static int do_fetch(struct transport *transport, free_refs(ref_map); return 1; } - - fetch_map = ref_map; + free_refs(ref_map); /* if neither --no-tags nor --tags was specified, do automated tag * following ... */ @@ -554,8 +553,6 @@ static int do_fetch(struct transport *transport, free_refs(ref_map); } - free_refs(fetch_map);