threads / patch / 12346

patchgit-remote: do not complain on multiple URLs for a remote

Subject: [PATCH] git-remote: do not complain on multiple URLs for a remote

## tl;dr

3 messages between Feb 27, 2008 and Feb 27, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Junio C Hamano· Feb 27, 2008, 21:55 UTC · lore

Having more than one URL for a remote is perfectly normal when the remote is defined to push to multiple places. Get rid of the annoying "Warning" message.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-remote.perl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Show changes to git-remote.perl +3 −3

diff --git a/git-remote.perl b/git-remote.perl
index 5cd6951..b30ed73 100755
--- a/git-remote.perl
+++ b/git-remote.perl
@@ -7,10 +7,10 @@ my $git = Git->repository();
 sub add_remote_config {
 	my ($hash, $name, $what, $value) = @_;
 	if ($what eq 'url') {
-		if (exists $hash->{$name}{'URL'}) {
-			print STDERR "Warning: more than one remote.$name.url\n";
+		# Having more than one is Ok -- it is used for push.
+		if (! exists $hash->{'URL'}) {
+			$hash->{$name}{'URL'} = $value;
 		}
-		$hash->{$name}{'URL'} = $value;
 	}
 	elsif ($what eq 'fetch') {
 		$hash->{$name}{'FETCH'} ||= [];

-- 
1.5.4.3.339.gad2d1

Johannes Schindelin· Feb 27, 2008, 22:19 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-remote: do not complain on multiple URLs for a remote

Hi,

On Wed, 27 Feb 2008, Junio C Hamano wrote:

> +		if (! exists $hash->{'URL'}) {

Is it preferred style now to add a space after "!"?

BTW I take this patch as a hint that I should resurrect builtin-remote...

Thanks, Dscho

Junio C Hamano· Feb 27, 2008, 22:51 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git-remote: do not complain on multiple URLs for a remote

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

> Hi,
>
> On Wed, 27 Feb 2008, Junio C Hamano wrote:
>
>> +		if (! exists $hash->{'URL'}) {
>
> Is it preferred style now to add a space after "!"?

No, just a copied line from another codepath.