# [PATCH] Correct fast-export file mode strings to match fast-import standard 2 messages from 2008-02-25 to 2008-02-26. Participants: Shawn O. Pearce, Johannes Schindelin. Thread: https://gitlist.dev/t/12307 ## Shawn O. Pearce, 2008-02-25 03:57 Subject: [PATCH] Correct fast-export file mode strings to match fast-import standard Message-ID: <20080225035728.GA26302@spearce.org> URL: https://gitlist.dev/e/20080225035728.GA26302%40spearce.org ``` The fast-import file format does not expect leading '0' in front of a file mode; that is we want '100644' and '0100644'. Thanks to Ian Clatworthy of the Bazaar project for noticing the difference in output/input. Signed-off-by: Shawn O. Pearce --- builtin-fast-export.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-fast-export.c b/builtin-fast-export.c index 49b54de..e1c5630 100755 --- a/builtin-fast-export.c +++ b/builtin-fast-export.c @@ -123,7 +123,7 @@ static void show_filemodify(struct diff_queue_struct *q, printf("D %s\n", spec->path); else { struct object *object = lookup_object(spec->sha1); - printf("M 0%06o :%d %s\n", spec->mode, + printf("M %06o :%d %s\n", spec->mode, get_object_mark(object), spec->path); } } -- 1.5.4.3.295.g6b554 ``` ## Johannes Schindelin, 2008-02-26 00:54 Subject: Re: [PATCH] Correct fast-export file mode strings to match fast-import standard Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0802260054000.3322%40eeepc-johanness In-Reply-To: <20080225035728.GA26302@spearce.org> ``` Hi, On Sun, 24 Feb 2008, Shawn O. Pearce wrote: > The fast-import file format does not expect leading '0' in front > of a file mode; that is we want '100644' and '0100644'. s/and/& not/ > - printf("M 0%06o :%d %s\n", spec->mode, > + printf("M %06o :%d %s\n", spec->mode, Definitely embarassing. Thanks, Dscho ```