# [PATCH] gitweb: Fix bugs in git_search_grep_body: it's length(), not len() 1 messages from 2008-02-23 to 2008-02-23. Participants: Jakub Narebski. Thread: https://gitlist.dev/t/12276 ## Jakub Narebski, 2008-02-23 21:37 Subject: [PATCH] gitweb: Fix bugs in git_search_grep_body: it's length(), not len() Message-ID: <20080223213449.16213.42233.stgit@localhost.localdomain> URL: https://gitlist.dev/e/20080223213449.16213.42233.stgit%40localhost.localdomain ``` Use int(/2) to get integer value for a substring length. Signed-off-by: Jakub Narebski --- I'm very very sorry. I though I have tested this, but somehow it slipped through; most probably I have tested older version. gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 326e27c..e8226b1 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3792,7 +3792,7 @@ sub git_search_grep_body { if ($line =~ m/^(.*)($search_regexp)(.*)$/i) { my ($lead, $match, $trail) = ($1, $2, $3); $match = chop_str($match, 70, 5); # in case match is very long - my $contextlen = (80 - len($match))/2; # is left for the remainder + my $contextlen = int((80 - length($match))/2); # for the remainder $contextlen = 30 if ($contextlen > 30); # but not too much $lead = chop_str($lead, $contextlen, 10); $trail = chop_str($trail, $contextlen, 10); ```