threads / patch / 12210

patchsend-email: squelch warning due to comparing undefined $_ to ""

Subject: [PATCH] send-email: squelch warning due to comparing undefined $_ to ""

## tl;dr

2 messages between Feb 20, 2008 and Feb 20, 2008. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Jay Soffian· Feb 20, 2008, 05:55 UTC · lore

The check to see if initial_reply_to is defined was also comparing $_ to "" for a reason I cannot ascertain (looking at the commit which made the change didn't provide enlightenment), but if $_ is undefined, perl generates a warning.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
Junio, the commit which introduced the change was yours, but I don't
see why you were comparing $_ to "".

http://repo.or.cz/w/git.git?a=commit;h=ace9c2a9dd7c9e54194998fc6b7c677dbb7d0902

 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-send-email.perl +1 −1

diff --git a/git-send-email.perl b/git-send-email.perl
index 59601e3..ccb87a2 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 
 	$initial_reply_to = $_;
 }
-if (defined $initial_reply_to && $_ ne "") {
+if (defined $initial_reply_to) {
 	$initial_reply_to =~ s/^\s*<?/</;
 	$initial_reply_to =~ s/>?\s*$/>/;
 }

-- 
1.5.4.2.208.gfb302

Junio C Hamano· Feb 20, 2008, 18:37 UTC · re: Jay Soffian · lore

Re: [PATCH] send-email: squelch warning due to comparing undefined $_ to ""

Jay Soffian <jaysoffian@gmail.com> writes:

Show 9 quoted lines

> The check to see if initial_reply_to is defined was also comparing $_ to
> "" for a reason I cannot ascertain (looking at the commit which made the
> change didn't provide enlightenment), but if $_ is undefined, perl
> generates a warning.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
> Junio, the commit which introduced the change was yours, but I don't
> see why you were comparing $_ to "".

I think it was meant to check for $initial_reply_to being empty (i.e. not compare $_ but the variable), but even if that is the case I do not think the check would make a difference.

So the patch looks good.  Thanks.