# [PATCH] git-gui: relax "dirty" version detection

2 messages from 2008-02-18 to 2008-02-20. Participants: Wincent Colaiuta, Shawn O. Pearce.
Thread: https://gitlist.dev/t/12170

## Wincent Colaiuta, 2008-02-18 08:36

Subject: [PATCH] git-gui: relax "dirty" version detection
Message-ID: <1203323793-18020-1-git-send-email-win@wincent.com>
URL: https://gitlist.dev/e/1203323793-18020-1-git-send-email-win%40wincent.com

```
"git gui" would complain at launch if the local version of Git was
"1.5.4.2.dirty". Loosen the regular expression to look for either
"-dirty" or ".dirty", thus eliminating spurious warnings.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
---
 git-gui/git-gui.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 5d65272..238a239 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -663,7 +663,7 @@ if {![regsub {^git version } $_git_version {} _git_version]} {
 }
 
 set _real_git_version $_git_version
-regsub -- {-dirty$} $_git_version {} _git_version
+regsub -- {[\-\.]dirty$} $_git_version {} _git_version
 regsub {\.[0-9]+\.g[0-9a-f]+$} $_git_version {} _git_version
 regsub {\.rc[0-9]+$} $_git_version {} _git_version
 regsub {\.GIT$} $_git_version {} _git_version
-- 
1.5.4.2.dirty

```

## Shawn O. Pearce, 2008-02-20 01:57

Subject: Re: [PATCH] git-gui: relax "dirty" version detection
Message-ID: <20080220015735.GW24004@spearce.org>
URL: https://gitlist.dev/e/20080220015735.GW24004%40spearce.org
In-Reply-To: <1203323793-18020-1-git-send-email-win@wincent.com>

```
Wincent Colaiuta <win@wincent.com> wrote:
> "git gui" would complain at launch if the local version of Git was
> "1.5.4.2.dirty". Loosen the regular expression to look for either
> "-dirty" or ".dirty", thus eliminating spurious warnings.
> 
> Signed-off-by: Wincent Colaiuta <win@wincent.com>

Thanks.  Its now queued in my maint branch.

-- 
Shawn.

```