threads / patch / 12092

patch, 5 partsFinish current packfile during fast-import crash handler

Subject: [PATCH 4/5] Finish current packfile during fast-import crash handler

## tl;dr

One message between Feb 14, 2008 and Feb 14, 2008. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn O. Pearce· Feb 14, 2008, 06:34 UTC · lore

If fast-import is in the middle of crashing due to a protocol error or something like that then it can be very useful to have the mark table and all objects up until that point be available for a new import to resume from.

Currently we just close the active packfile, unkeep all of our newly created packfiles (so they can be deleted), and dump the marks table to a temporary file.

We don't attempt to update the refs/tags that the process has in memory as much of that data can be found in the crash report and I'm not sure it would be the right thing to do under every type of crash.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 fast-import.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
Show changes to fast-import.c +7 −0
diff --git a/fast-import.c b/fast-import.c
index 117f38c..0d3449f 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -459,6 +459,10 @@ static void write_crash_report(const char *err)
 	fclose(rpt);
 }
 
+static void end_packfile(void);
+static void unkeep_all_packs(void);
+static void dump_marks(void);
+
 static NORETURN void die_nicely(const char *err, va_list params)
 {
 	static int zombie;
@@ -472,6 +476,9 @@ static NORETURN void die_nicely(const char *err, va_list params)
 	if (!zombie) {
 		zombie = 1;
 		write_crash_report(message);
+		end_packfile();
+		unkeep_all_packs();
+		dump_marks();
 	}
 	exit(128);
 }
-- 
1.5.4.1.1309.g833c2

← back to recent threads