# [PATCH] diff.c: replace a 'strdup' with 'xstrdup'.

2 messages from 2008-02-14 to 2008-02-15. Participants: Christian Couder, Junio C Hamano.
Thread: https://gitlist.dev/t/12083

## Christian Couder, 2008-02-14 05:50

Subject: [PATCH] diff.c: replace a 'strdup' with 'xstrdup'.
Message-ID: <20080214065000.083c3617.chriscool@tuxfamily.org>
URL: https://gitlist.dev/e/20080214065000.083c3617.chriscool%40tuxfamily.org

```
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 diff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

	By the way perhaps the 

 		return error("%s: lacks value", var);

	should also be changed to

		return config_error_nonbool(var);

	or the check could be removed because there is
	already a check line 171 just before
	'parse_lldiff_command' is called.

diff --git a/diff.c b/diff.c
index cd8bc4d..e5db293 100644
--- a/diff.c
+++ b/diff.c
@@ -88,7 +88,7 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val
 
 	if (!value)
 		return error("%s: lacks value", var);
-	drv->cmd = strdup(value);
+	drv->cmd = xstrdup(value);
 	return 0;
 }
 
-- 
1.5.4.20.gc135a-dirty

```

## Junio C Hamano, 2008-02-15 17:11

Subject: Re: [PATCH] diff.c: replace a 'strdup' with 'xstrdup'.
Message-ID: <7vlk5mi1qs.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vlk5mi1qs.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <20080214065000.083c3617.chriscool@tuxfamily.org>

```
Christian Couder <chriscool@tuxfamily.org> writes:

> 	By the way perhaps the 
>
>  		return error("%s: lacks value", var);
>
> 	should also be changed to
>
> 		return config_error_nonbool(var);

Good eyes.  That probably should go to 'maint' for consistency.

```