# [PATCH] Fix "git submodule status" output when "git describe" is not possible 3 messages from 2008-02-13 to 2008-02-24. Participants: Alberto Bertogli, Junio C Hamano. Thread: https://gitlist.dev/t/12065 ## Alberto Bertogli, 2008-02-13 00:19 Subject: [PATCH] Fix "git submodule status" output when "git describe" is not possible Message-ID: <1202861986-1159-1-git-send-email-albertito@gmail.com> URL: https://gitlist.dev/e/1202861986-1159-1-git-send-email-albertito%40gmail.com ``` When a submodule cannot be described, doing a "git submodule status" on the supermodule produces unnecesary and scary output, for example: fatal: cannot describe 'cac575f1bccf0c6942d11962cf4d44ba974d3e8e' cac575f1bccf0c6942d11962cf4d44ba974d3e8e megaco/megaco_tipc Where it should just show: cac575f1bccf0c6942d11962cf4d44ba974d3e8e megaco/megaco_tipc The culprit (after manual inspection of git log) seems to be commit a2cf9f4. This patch fixes this by making git submodule aware of that behaviour change. Signed-off-by: Alberto Bertogli --- git-submodule.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index a6aaf40..5e8b84f 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -315,7 +315,7 @@ set_name_rev () { cd "$1" && { git describe "$2" 2>/dev/null || git describe --tags "$2" 2>/dev/null || - git describe --contains --tags "$2" + git describe --contains --tags "$2" 2>/dev/null } ) ) test -z "$revname" || revname=" ($revname)" -- 1.5.4.1.1279.g0d205f-dirty ``` ## Junio C Hamano, 2008-02-13 01:01 Subject: Re: [PATCH] Fix "git submodule status" output when "git describe" is not possible Message-ID: <7vprv1zn27.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vprv1zn27.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1202861986-1159-1-git-send-email-albertito@gmail.com> ``` Alberto Bertogli writes: > When a submodule cannot be described, doing a "git submodule status" on > the supermodule produces unnecesary and scary output,... I had an impression that describe got a new feature for a case like this recently. ``` ## Alberto Bertogli, 2008-02-24 20:49 Subject: Re: [PATCH] Fix "git submodule status" output when "git describe" is not possible Message-ID: <20080224204939.GE10119@gmail.com> URL: https://gitlist.dev/e/20080224204939.GE10119%40gmail.com In-Reply-To: <7vprv1zn27.fsf@gitster.siamese.dyndns.org> ``` On Tue, Feb 12, 2008 at 05:01:52PM -0800, Junio C Hamano wrote: > Alberto Bertogli writes: > > > When a submodule cannot be described, doing a "git submodule status" on > > the supermodule produces unnecesary and scary output,... > > I had an impression that describe got a new feature for a case > like this recently. I'm sorry but I've read the docs and tried with a few options and I have no idea what that one may be. The bug is still present on 'next' as of an hour ago. Thanks, Alberto ```