# Using thunderbird to post/apply patches? 9 messages from 2008-02-07 to 2008-02-08. Participants: Martin Langhoff, Johannes Schindelin, Brandon Casey, Jay Soffian, Junio C Hamano. Thread: https://gitlist.dev/t/11956 ## Martin Langhoff, 2008-02-07 23:21 Subject: Using thunderbird to post/apply patches? Message-ID: <46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com> URL: https://gitlist.dev/e/46a038f90802071521n674b61c2t5e4d4c740375b951%40mail.gmail.com ``` Is there anyone using thunderbird/mozilla to post patches with additional email commentary like Junio and Linus do? Are there good tricks for this? Or otherwise a similar MUA that does things right? The 2 workflows I am after are... - Load up a patch created with git-format-patch into my email editor to add some commentary before sending. Should not munge the patch itself! - Feed an email I am reading to git-apply-mbox so that if it's reasonably formatted as a patch it will do the right thing and apply it. cheers, m ``` ## Johannes Schindelin, 2008-02-07 23:34 Subject: Re: Using thunderbird to post/apply patches? Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0802072333120.11591%40racer.site In-Reply-To: <46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com> ``` Hi, On Fri, 8 Feb 2008, Martin Langhoff wrote: > Is there anyone using thunderbird/mozilla to post patches with > additional email commentary like Junio and Linus do? Are there good > tricks for this? Or otherwise a similar MUA that does things right? > > The 2 workflows I am after are... > > - Load up a patch created with git-format-patch into my email editor > to add some commentary before sending. Should not munge the patch > itself! The "Thunderbird" section in Documentation/SubmittingPatches should help here. > - Feed an email I am reading to git-apply-mbox so that if it's > reasonably formatted as a patch it will do the right thing and apply > it. Recently, git-am learnt to apply mails in maildir format. Thunderbird uses maildir format internally, if I am not mistaken. Hth, Dscho ``` ## Martin Langhoff, 2008-02-07 23:42 Subject: Re: Using thunderbird to post/apply patches? Message-ID: <46a038f90802071542j765a8501kc57b065f22c734b2@mail.gmail.com> URL: https://gitlist.dev/e/46a038f90802071542j765a8501kc57b065f22c734b2%40mail.gmail.com In-Reply-To: ``` On Feb 8, 2008 12:34 PM, Johannes Schindelin wrote: > The "Thunderbird" section in Documentation/SubmittingPatches should help > here. If that's state-of-the-art then thunderbird hasn't gotten any better since I last tried. Shame. > > - Feed an email I am reading to git-apply-mbox so that if it's > > reasonably formatted as a patch it will do the right thing and apply > > it. > > Recently, git-am learnt to apply mails in maildir format. Thunderbird > uses maildir format internally, if I am not mistaken. It uses mbox - but the delimiter is somewhat broken, so sometimes git-am fails to split the emails correctly. A pretty sad story overall. Grumble... m ``` ## Brandon Casey, 2008-02-07 23:44 Subject: Re: Using thunderbird to post/apply patches? Message-ID: <47AB97EC.8030002@nrlssc.navy.mil> URL: https://gitlist.dev/e/47AB97EC.8030002%40nrlssc.navy.mil In-Reply-To: <46a038f90802071521n674b61c2t5e4d4c740375b951@mail.gmail.com> ``` Martin Langhoff wrote: > Is there anyone using thunderbird/mozilla to post patches with > additional email commentary like Junio and Linus do? Are there good > tricks for this? Or otherwise a similar MUA that does things right? > > The 2 workflows I am after are... > > - Load up a patch created with git-format-patch into my email editor > to add some commentary before sending. Should not munge the patch > itself! I use git-send-email to first send the patch to myself. When it shows up in thunderbird, I Right-click and select "Edit As New..." Add my text, update the recipients, and voila. If you're replying to a previous message, you can get the Message-ID to supply to git-send-email by selecting View->Headers->All. Copy&Paste everything between the angle brackets. I have these options set in Edit->Preferences: Display->Formatting->Display emoticons as graphics: unchecked, it turns HEAD^2 into HEAD squared Composition->General->Wrap plain text messages at 0 characters ^ I also have mailnews.send_plaintext_flowed => false as suggested in SubmittingPatches. There is a different suggestion in that document you may want to read. > - Feed an email I am reading to git-apply-mbox so that if it's > reasonably formatted as a patch it will do the right thing and apply > it. I just Right-click and Save As... cat | git am -brandon ``` ## Johannes Schindelin, 2008-02-08 00:12 Subject: Re: Using thunderbird to post/apply patches? Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0802080011420.11591%40racer.site In-Reply-To: <46a038f90802071542j765a8501kc57b065f22c734b2@mail.gmail.com> ``` Hi, On Fri, 8 Feb 2008, Martin Langhoff wrote: > On Feb 8, 2008 12:34 PM, Johannes Schindelin > wrote: > > > Martin wrote: > > > > > - Feed an email I am reading to git-apply-mbox so that if it's > > > reasonably formatted as a patch it will do the right thing and apply > > > it. > > > > Recently, git-am learnt to apply mails in maildir format. > > Thunderbird uses maildir format internally, if I am not mistaken. > > It uses mbox - but the delimiter is somewhat broken, so sometimes git-am > fails to split the emails correctly. > > A pretty sad story overall. Grumble... Do you have an example of a non-working mbox for git-am? Thanks, Dscho ``` ## Jay Soffian, 2008-02-08 04:10 Subject: Re: Using thunderbird to post/apply patches? Message-ID: <76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com> URL: https://gitlist.dev/e/76718490802072010x63e2082akf1aa92b12cd24030%40mail.gmail.com In-Reply-To: <47AB97EC.8030002@nrlssc.navy.mil> ``` On Feb 7, 2008 6:44 PM, Brandon Casey wrote: > I also have mailnews.send_plaintext_flowed => false as suggested in > SubmittingPatches. Would teaching git-mailsplit to handle format=flowed be considered a useful contribution? (W/o sounding like a total script weenie, I'm actually wondering if converting git-am, git-mailsplit, and git-mailinfo to Perl code wouldn't be a bad idea... groking email is a lot more pleasant in Perl than shell and/or C.) j. ``` ## Martin Langhoff, 2008-02-08 04:27 Subject: Re: Using thunderbird to post/apply patches? Message-ID: <46a038f90802072027h759114b1l3a2b861505eded2c@mail.gmail.com> URL: https://gitlist.dev/e/46a038f90802072027h759114b1l3a2b861505eded2c%40mail.gmail.com In-Reply-To: ``` On Feb 8, 2008 1:12 PM, Johannes Schindelin wrote: > Do you have an example of a non-working mbox for git-am? good news - tested the mbox files I have (which used to get git-am to barf back in the v0.99 days), and they work well. So things have gotten much better on that front... probably git mailsplit got smarter. I doubt thunderbird has changed one bit :-) cheers! m ``` ## Junio C Hamano, 2008-02-08 07:26 Subject: Re: Using thunderbird to post/apply patches? Message-ID: <7vejbnlxhz.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vejbnlxhz.fsf%40gitster.siamese.dyndns.org In-Reply-To: <76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com> ``` "Jay Soffian" writes: > On Feb 7, 2008 6:44 PM, Brandon Casey wrote: > >> I also have mailnews.send_plaintext_flowed => false as suggested in >> SubmittingPatches. > > Would teaching git-mailsplit to handle format=flowed be considered a > useful contribution? In the way the e-mail processing toolchain is structured, I think git-mailinfo is the logical place to do that, not git-mailsplit. It already knows how to unwrap single level of MIME multi-part and also CTE. ``` ## Johannes Schindelin, 2008-02-08 11:38 Subject: Re: Using thunderbird to post/apply patches? Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0802081135080.11591%40racer.site In-Reply-To: <76718490802072010x63e2082akf1aa92b12cd24030@mail.gmail.com> ``` Hi, On Thu, 7 Feb 2008, Jay Soffian wrote: > On Feb 7, 2008 6:44 PM, Brandon Casey wrote: > > > I also have mailnews.send_plaintext_flowed => false as suggested in > > SubmittingPatches. > > Would teaching git-mailsplit to handle format=flowed be considered a > useful contribution? > > (W/o sounding like a total script weenie, I'm actually wondering if > converting git-am, git-mailsplit, and git-mailinfo to Perl code wouldn't > be a bad idea... groking email is a lot more pleasant in Perl than shell > and/or C.) FWIW I think you have it backwards. It might look nicer in Perl, but we try very hard to consolidate the major pieces into C code. This is done for several reasons: - reducing dependencies (not everybody needs all git programs, so it even helps if one script is converted at a time), and - making the experience nicer on Windows (reducing the foot-print, since Perl is _not_ commonly installed, and drastically improving performance, since the number of processes is reduced). So no, I would not like these scripts being converted (back?) to scripts. Thank you, Dscho ```