# [PATCH] git-p4: Fix an obvious typo 2 messages from 2008-02-02 to 2008-02-03. Participants: Tommy Thorn, Simon Hausmann. Thread: https://gitlist.dev/t/11831 ## Tommy Thorn, 2008-02-02 08:11 Subject: [PATCH] git-p4: Fix an obvious typo Message-ID: <182304.89601.qm@web39507.mail.mud.yahoo.com> URL: https://gitlist.dev/e/182304.89601.qm%40web39507.mail.mud.yahoo.com ``` The regexp "$," can't match anything. Clearly not intended. This was introduced in ce6f33c8 which is quite a while ago. Signed-off-by: Tommy Thorn --- contrib/fast-import/git-p4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index c80a6da..553e237 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -1670,7 +1670,7 @@ class P4Clone(P4Sync): depotPath = args[0] depotDir = re.sub("(@[^@]*)$", "", depotPath) depotDir = re.sub("(#[^#]*)$", "", depotDir) - depotDir = re.sub(r"\.\.\.$,", "", depotDir) + depotDir = re.sub(r"\.\.\.$", "", depotDir) depotDir = re.sub(r"/$", "", depotDir) return os.path.split(depotDir)[1] -- 1.5.4.rc5.5.gab98 ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs ``` ## Simon Hausmann, 2008-02-03 18:36 Subject: Re: [PATCH] git-p4: Fix an obvious typo Message-ID: <200802031936.02828.simon@lst.de> URL: https://gitlist.dev/e/200802031936.02828.simon%40lst.de In-Reply-To: <182304.89601.qm@web39507.mail.mud.yahoo.com> ``` On Saturday 02 February 2008 09:11:44 Tommy Thorn wrote: > The regexp "$," can't match anything. Clearly not intended. > > This was introduced in ce6f33c8 which is quite a while ago. > > Signed-off-by: Tommy Thorn Acked-by: Simon Hausmann Simon > --- > contrib/fast-import/git-p4 | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 > index c80a6da..553e237 100755 > --- a/contrib/fast-import/git-p4 > +++ b/contrib/fast-import/git-p4 > @@ -1670,7 +1670,7 @@ class P4Clone(P4Sync): > depotPath = args[0] > depotDir = re.sub("(@[^@]*)$", "", depotPath) > depotDir = re.sub("(#[^#]*)$", "", depotDir) > - depotDir = re.sub(r"\.\.\.$,", "", depotDir) > + depotDir = re.sub(r"\.\.\.$", "", depotDir) > depotDir = re.sub(r"/$", "", depotDir) > return os.path.split(depotDir)[1] ```