threads / patch / 11766

patch, 2 partsDocumentation: config: add "browser.<tool>.path".

Subject: [PATCH 1/2] Documentation: config: add "browser.<tool>.path".

## tl;dr

3 messages between Jan 28, 2008 and Jan 29, 2008. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Christian Couder· Jan 28, 2008, 07:02 UTC · lore

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Documentation/config.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Show changes to Documentation/config.txt +4 −0

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 877eda9..c2fedd1 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -367,6 +367,10 @@ branch.<name>.rebase::
 	it unless you understand the implications (see linkgit:git-rebase[1]
 	for details).
 
+browser.<tool>.path::
+	Override the path for the given tool that may be used to
+	browse help. See linkgit:git-help[1].
+
 clean.requireForce::
 	A boolean to make git-clean do nothing unless given -f
 	or -n.   Defaults to true.

-- 
1.5.4.rc4.16.g1009

Junio C Hamano· Jan 28, 2008, 07:36 UTC · re: Christian Couder · lore

Re: [PATCH 1/2] Documentation: config: add "browser.<tool>.path".

Christian Couder <chriscool@tuxfamily.org> writes:

Show 17 quoted lines

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  Documentation/config.txt |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 877eda9..c2fedd1 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -367,6 +367,10 @@ branch.<name>.rebase::
>  	it unless you understand the implications (see linkgit:git-rebase[1]
>  	for details).
>  
> +browser.<tool>.path::
> +	Override the path for the given tool that may be used to
> +	browse help. See linkgit:git-help[1].
> +

Thanks.

I wonder if we want to stress the fact that this is about rendering HTML version of the manual. IOW, the <tool>.path is about the path the chosen HTML renderer program is at, and not consulted at all unless "git help -w help" is run.

Also, do we want to list the repertoire of <tool>? Unlike <name> in "remote.<name>.url" and "branch.<name>.remote", this is not something the end user can arbitrarily name.

Incidentally, I notice that git-help manual page does not list what browsers are supported (except that it hints that firefox is usable by having an example "browser.firefox.path"), even though it tells how the browser is picked via "*.browser".

Christian Couder· Jan 29, 2008, 06:07 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/2] Documentation: config: add "browser.<tool>.path".

Le lundi 28 janvier 2008, Junio C Hamano a écrit :

Show 22 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
> >
> > +browser.<tool>.path::
> > +	Override the path for the given tool that may be used to
> > +	browse help. See linkgit:git-help[1].
> > +
>
> Thanks.
>
> I wonder if we want to stress the fact that this is about
> rendering HTML version of the manual.  IOW, the <tool>.path
> is about the path the chosen HTML renderer program is at, and
> not consulted at all unless "git help -w help" is run.
>
> Also, do we want to list the repertoire of <tool>?  Unlike
> <name> in "remote.<name>.url" and "branch.<name>.remote", this
> is not something the end user can arbitrarily name.
>
> Incidentally, I notice that git-help manual page does not list
> what browsers are supported (except that it hints that firefox
> is usable by having an example "browser.firefox.path"), even
> though it tells how the browser is picked via "*.browser".

It should be fixed in the following patch series.

Thanks, Christian.